Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running multithreaded: Add an IOSvc, an algorithm for reading and writing for functionals in k4FWCore #173

Merged
merged 127 commits into from
May 21, 2024
Merged

Support running multithreaded: Add an IOSvc, an algorithm for reading and writing for functionals in k4FWCore #173

merged 127 commits into from
May 21, 2024

Commits on Apr 25, 2024

  1. Add an IOSvc, an algorithm for reading and writing

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a0bf553 View commit details
    Browse the repository at this point in the history

  2. Working example with new Consumers

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    462af5f View commit details
    Browse the repository at this point in the history

  3. Make changes, everything working except reading from multiple files

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    64026ef View commit details
    Browse the repository at this point in the history

  4. Add fixes to read multiple collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2a91804 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e434386 View commit details
    Browse the repository at this point in the history

  6. Add another test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9428e4c View commit details
    Browse the repository at this point in the history

  7. Add changes to make multithreading reading and writing work

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5e7368c View commit details
    Browse the repository at this point in the history

  8. Add changes to read multiple collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2cb92bf View commit details
    Browse the repository at this point in the history

  9. Add functionality to read multiple collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6b727d3 View commit details
    Browse the repository at this point in the history

  10. Change to ROOTReader and ROOTWriter

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8394e2a View commit details
    Browse the repository at this point in the history

  11. Add reading multiple sets of multiple collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b609670 View commit details
    Browse the repository at this point in the history

  12. Add a new version of the consumer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a237f64 View commit details
    Browse the repository at this point in the history

  13. Add the old version of the consumer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3426bd5 View commit details
    Browse the repository at this point in the history

  14. Add reading maps of edm4hep collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b57f985 View commit details
    Browse the repository at this point in the history

  15. Make some clean up in the consumer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    35a3255 View commit details
    Browse the repository at this point in the history

  16. Add the python folder

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    59170f0 View commit details
    Browse the repository at this point in the history

  17. Delete another unused test file

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    98099f7 View commit details
    Browse the repository at this point in the history

  18. Fix a few tests by making all the parameters lists

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f71df09 View commit details
    Browse the repository at this point in the history

  19. Add a new transformer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    327d252 View commit details
    Browse the repository at this point in the history

  20. Fix the producers

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2459397 View commit details
    Browse the repository at this point in the history

  21. Make all properties not be lists

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    eaeebb2 View commit details
    Browse the repository at this point in the history

  22. Add a hash function for hidden properties

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6469a62 View commit details
    Browse the repository at this point in the history

  23. Simplify and clean up the consumer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ec210e6 View commit details
    Browse the repository at this point in the history

  24. Fix tests to not only work with lists

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2f8884c View commit details
    Browse the repository at this point in the history

  25. Add reading and writing from any to any in the transformer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    00664a5 View commit details
    Browse the repository at this point in the history

  26. Use ROOTWriter

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1c87a64 View commit details
    Browse the repository at this point in the history

  27. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7ba4419 View commit details
    Browse the repository at this point in the history

  28. Comment out the RNTuple readers and writers

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d1b2770 View commit details
    Browse the repository at this point in the history

  29. Use PROJECT_NAME

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    21d5b3b View commit details
    Browse the repository at this point in the history

  30. Change the order of the python directory for tests

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d617e88 View commit details
    Browse the repository at this point in the history

  31. Install the python files to one of the build directories

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    926f7c2 View commit details
    Browse the repository at this point in the history

  32. Use CMAKE_CURRENT_LIST_DIR for this test to make dependent tests pass

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2b05dda View commit details
    Browse the repository at this point in the history

  33. Fix syntax

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    783debb View commit details
    Browse the repository at this point in the history

  34. Use getAvailableCollections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cc07d96 View commit details
    Browse the repository at this point in the history

  35. Fix test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1e25926 View commit details
    Browse the repository at this point in the history

  36. Fix tests

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d261c2b View commit details
    Browse the repository at this point in the history

  37. Don't install

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f01c0eb View commit details
    Browse the repository at this point in the history

  38. Comment out

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    365cfda View commit details
    Browse the repository at this point in the history

  39. Copy some files for tests

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be277ba View commit details
    Browse the repository at this point in the history

  40. Change order

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4d97dbc View commit details
    Browse the repository at this point in the history

  41. Try this

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    18778dd View commit details
    Browse the repository at this point in the history

  42. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e06e489 View commit details
    Browse the repository at this point in the history

  43. Remove a couple of files

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    72496cb View commit details
    Browse the repository at this point in the history

  44. More format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2686d8b View commit details
    Browse the repository at this point in the history

  45. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9307ba8 View commit details
    Browse the repository at this point in the history

  46. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    62aaa44 View commit details
    Browse the repository at this point in the history

  47. Add the genConfDir that seems to be necessary sometimes 

    for running the tests without installing
    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cac24cb View commit details
    Browse the repository at this point in the history

  48. Improve test command and test output when it fails

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ee4519e View commit details
    Browse the repository at this point in the history

  49. Don't try to create any directories for inputs

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    487c2a6 View commit details
    Browse the repository at this point in the history

  50. Remove info message

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9ae5f73 View commit details
    Browse the repository at this point in the history

  51. Use a SmartIF for the HiveWhiteBoard instead of a ServiceHandle 

    since we don't always want to have it and it emits a warning when it
can't find the HiveWhiteBoard
    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f0bb6e0 View commit details
    Browse the repository at this point in the history

  52. Add a sequencer for writing

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    24db3a4 View commit details
    Browse the repository at this point in the history

  53. Remove brackets

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cb92395 View commit details
    Browse the repository at this point in the history

  54. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5954d05 View commit details
    Browse the repository at this point in the history

  55. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e27742a View commit details
    Browse the repository at this point in the history

  56. Delete old files and remove debugging warnings

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0b15c1a View commit details
    Browse the repository at this point in the history

  57. Fix a few tests and add some comments

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    dfef5ae View commit details
    Browse the repository at this point in the history

  58. Change a few imports

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ccf4ff2 View commit details
    Browse the repository at this point in the history

  59. Add a test for writing 0 collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8dbcaa2 View commit details
    Browse the repository at this point in the history

  60. Fix warning

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b01fa5d View commit details
    Browse the repository at this point in the history

  61. Fix test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6ac240d View commit details
    Browse the repository at this point in the history

  62. Remove old file

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    446ccb6 View commit details
    Browse the repository at this point in the history

  63. Update the transformers not to use std::shared_ptr in the output

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f9b0bad View commit details
    Browse the repository at this point in the history

  64. Update the consumer not to use shared_ptr and use references instead

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2062d98 View commit details
    Browse the repository at this point in the history

  65. Format

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6154232 View commit details
    Browse the repository at this point in the history

  66. References should be const

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b7ab80c View commit details
    Browse the repository at this point in the history

  67. Enforce references being const

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    624158e View commit details
    Browse the repository at this point in the history

  68. Modify the transformer not to use std::shared_ptr in the inputs

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a9f5cec View commit details
    Browse the repository at this point in the history

  69. Fix a few includes

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f0d5dd6 View commit details
    Browse the repository at this point in the history

  70. Move readMapInputs to FunctionalUtils.h

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f23ad30 View commit details
    Browse the repository at this point in the history

  71. Clean up and remove ExtractInnerType

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7f68c31 View commit details
    Browse the repository at this point in the history

  72. Formatting and clean up

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6f4d0bf View commit details
    Browse the repository at this point in the history

  73. Use the new reader and writer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    70ef4a8 View commit details
    Browse the repository at this point in the history

  74. Fix the FunctionalMemory test as it was intended to be (no IO)

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f009f3a View commit details
    Browse the repository at this point in the history

  75. Clean up includes and use k4FWCore::frameLocation

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5074526 View commit details
    Browse the repository at this point in the history

  76. Move the destructor comment, use .reset() and std::make_shared

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    40b1b3f View commit details
    Browse the repository at this point in the history

  77. Clean up and fix a test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    576a257 View commit details
    Browse the repository at this point in the history

  78. Fix writing an arbitrary number of collections

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7299916 View commit details
    Browse the repository at this point in the history

  79. Create all the needed data handles for the consumer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a8335d1 View commit details
    Browse the repository at this point in the history

  80. Create the right handles when using the transformer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4ade0f3 View commit details
    Browse the repository at this point in the history

  81. Remove remaining GaudiAlg headers

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    70099c7 View commit details
    Browse the repository at this point in the history

  82. Make inputs and outputs lists

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    01d6751 View commit details
    Browse the repository at this point in the history

  83. Add a few comments and a requirement on is_map_like

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9de8b81 View commit details
    Browse the repository at this point in the history

  84. Add asserts to have error messages when using a disallowed type

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    dbc1b35 View commit details
    Browse the repository at this point in the history

  85. Check the services interfaces in IOSvc.cpp

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    821b8f3 View commit details
    Browse the repository at this point in the history

  86. Add Service::initialize in IOSvc.cpp

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    42551fd View commit details
    Browse the repository at this point in the history

  87. Fix Service::initialize and clean up template functions

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8b7a162 View commit details
    Browse the repository at this point in the history

  88. Apply suggestions from code review 

    Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Mateusz Jakub Fila <[email protected]>
    @jmcarcell @andresailer @m-fila
    3 people committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e56f68f View commit details
    Browse the repository at this point in the history

  89. Apply suggestions for Writer.cpp 

    Co-authored-by: Andre Sailer <[email protected]>
    @jmcarcell @andresailer
    jmcarcell and andresailer committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0256dad View commit details
    Browse the repository at this point in the history

  90. Allow combining functionals together with old algorithms

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    197db77 View commit details
    Browse the repository at this point in the history

  91. Remove unused ctx

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7029ffd View commit details
    Browse the repository at this point in the history

  92. Fix typo

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    97b1c3c View commit details
    Browse the repository at this point in the history

  93. Address a few comments in the PR

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d9a58e7 View commit details
    Browse the repository at this point in the history

  94. Add error when a frame can't be pushed

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9b1cf05 View commit details
    Browse the repository at this point in the history

  95. Fix properties docstrings

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    35cbb47 View commit details
    Browse the repository at this point in the history

  96. Use isMapToCollLike_v

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    797dfe3 View commit details
    Browse the repository at this point in the history

  97. Return StatusCode::FAILURE instead of throwing

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be69179 View commit details
    Browse the repository at this point in the history

  98. Add an error message

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    936638e View commit details
    Browse the repository at this point in the history

  99. Format a few files

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d6de2e2 View commit details
    Browse the repository at this point in the history

  100. Do a bit of cleanup and small fixes

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9357347 View commit details
    Browse the repository at this point in the history

  101. Add a few comments to the Transformer

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ad7b8c9 View commit details
    Browse the repository at this point in the history

  102. Open a file to get the collections before running

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fc5d25c View commit details
    Browse the repository at this point in the history

  103. Change one test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a40f42e View commit details
    Browse the repository at this point in the history

  104. Remove the remaining GaudiAlgs

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c14b230 View commit details
    Browse the repository at this point in the history

  105. Change EvtDataSvc to EventDataSvc

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4f7433b View commit details
    Browse the repository at this point in the history

  106. Add missing test

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ade9bbd View commit details
    Browse the repository at this point in the history

  107. Fix list of tests

    @jmcarcell
    jmcarcell committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    11e68e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Fix test (finally)

    @jmcarcell
    jmcarcell committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    969672a View commit details
    Browse the repository at this point in the history

  2. Fix style

    @jmcarcell
    jmcarcell committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4c04e8f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Fix parrallel running with a Sequencer, add tests and clean up

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3a4e216 View commit details
    Browse the repository at this point in the history

  2. Add comments in the python files

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3765ea2 View commit details
    Browse the repository at this point in the history

  3. Bring back the output from a test

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8897c20 View commit details
    Browse the repository at this point in the history

  4. Add new line 

    Co-authored-by: Andre Sailer <[email protected]>
    @jmcarcell @andresailer
    jmcarcell and andresailer authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    adc3d68 View commit details
    Browse the repository at this point in the history

  5. Try to fix failing test

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    12ea14f View commit details
    Browse the repository at this point in the history

  6. Clean up the Writer and add comments

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7dd3055 View commit details
    Browse the repository at this point in the history

  7. Fix style and clean up

    @jmcarcell
    jmcarcell committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1c4690f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Have the runFunctionalMix tests run with a single steering file

    @jmcarcell
    jmcarcell committed May 15, 2024
    Configuration menu
    Copy the full SHA
    312725d View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Use ShortCircuit=False 

    Co-authored-by: Mateusz Jakub Fila <[email protected]>
    @jmcarcell @m-fila
    jmcarcell and m-fila authored May 21, 2024
    Configuration menu
    Copy the full SHA
    cd6b938 View commit details
    Browse the repository at this point in the history

  2. Fix typo 

    Co-authored-by: Mateusz Jakub Fila <[email protected]>
    @jmcarcell @m-fila
    jmcarcell and m-fila authored May 21, 2024
    Configuration menu
    Copy the full SHA
    663b097 View commit details
    Browse the repository at this point in the history

  3. Use emplace_back 

    Co-authored-by: Mateusz Jakub Fila <[email protected]>
    @jmcarcell @m-fila
    jmcarcell and m-fila authored May 21, 2024
    Configuration menu
    Copy the full SHA
    8c6893e View commit details
    Browse the repository at this point in the history

  4. Remove some comments

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f5fdcf3 View commit details
    Browse the repository at this point in the history

  5. Use isReEntrant for the Writer

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1e8d0cc View commit details
    Browse the repository at this point in the history

  6. Fix pre-commit

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e796ac3 View commit details
    Browse the repository at this point in the history

  7. Fix workflow files

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dc6e736 View commit details
    Browse the repository at this point in the history

  8. Use alma9

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6409c2f View commit details
    Browse the repository at this point in the history

  9. Go back to centos7

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e073c00 View commit details
    Browse the repository at this point in the history

  10. Fix path

    @jmcarcell
    jmcarcell committed May 21, 2024
    Configuration menu
    Copy the full SHA
    afd2856 View commit details
    Browse the repository at this point in the history