Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use GaudiAlg #172

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Don't use GaudiAlg #172

merged 6 commits into from
Mar 15, 2024

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

This can also serve as example for other repos, basically adding a const EventContext& in the arguments to execute and making execute const and changing GaudiAlgorithm to Gaudi::Algorithm. Headers change too: GaudiAlg/GaudiAlgorithm.h to Gaudi/Algorithm.h

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am not sure we should keep all the "old" examples for creating example data, because I don't think our DataHandle is thread safe enough to just b marked mutable.

@jmcarcell
Copy link
Contributor Author

Alternative proposal (changes in the last commit): Remove the UniquePtr test which isn't doing anything than the other tests are not doing and set Cardinality to 1 which is how algorithms that can't run in parallel are set, for example: https://gitlab.cern.ch/gaudi/Gaudi/-/blob/master/GaudiKernel/include/GaudiKernel/Algorithm.h#L24

Having some algorithms around is good because not everything will be functional and it also allows to test if they can be mixed together.

@jmcarcell
Copy link
Contributor Author

If there aren't any more complaints I'll merge this today. I think the plan is to remove GaudiAlg for the version 40 of Gaudi so there is time but there are a few repos that have to be changed

@tmadlener
Copy link
Contributor

I think this looks good. One thing that is not entirely clear to me: Is the EventContext usable in any meaningful way for a "normal" algorithm? Or is that just used by the scheduler to make sure to use the right inputs?

@jmcarcell
Copy link
Contributor Author

I'm not sure I have seen that being used by an algorithm. There is an event number that could be used for seeding I guess but we have that information in the headers

@jmcarcell jmcarcell merged commit 017cba2 into main Mar 15, 2024
5 of 11 checks passed
@jmcarcell jmcarcell deleted the gaudialg branch March 15, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants