Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy component that depend on the podio EventStore #171

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Dec 8, 2023

BEGINRELEASENOTES

  • Remove the legacy components that depend on the podio EventStore. This is a breaking change for anyone still using any of PodioLegacyInput, PodioLegacyOutput or k4LegacyDataSvc.
    • If you still need the functionality to read old / lecagy input files, please let us know (e.g. via an issue).

ENDRELEASENOTES

I think now is a good time to do this since we have just made a release so that people can always go back to that in case this breaks things on the nightlies for them. We could then also figure out who is actually still using things legacy files and take things from there.

  • Check if this impacts other downstream packages

@tmadlener tmadlener changed the title [WIP] Remove the legacy component that depend on the podio EventStore Remove the legacy component that depend on the podio EventStore Dec 11, 2023
@tmadlener
Copy link
Contributor Author

It looks like we have switched over all our packages over to the non-legacy datasvc already. At least I could build a stack locally with these changes in without any further changes.

@tmadlener
Copy link
Contributor Author

As discussed at todays meeting we will merge this now and see if there are any complaints, resp. whether someone still needs this functionality.

@tmadlener tmadlener merged commit 2fba18c into key4hep:main Dec 12, 2023
3 of 5 checks passed
@tmadlener tmadlener deleted the remove-podio-eventstore branch December 12, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant