Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create output directories #170

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Create output directories #170

merged 6 commits into from
Mar 25, 2024

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Dec 5, 2023

BEGINRELEASENOTES

  • Output directories are created if they don't exist.

ENDRELEASENOTES

andresailer
andresailer reviewed Dec 5, 2023
View reviewed changes
k4FWCore/components/PodioOutput.cpp Outdated Show resolved Hide resolved
k4FWCore/components/PodioOutput.cpp Outdated Show resolved Hide resolved
k4FWCore/components/PodioOutput.cpp Outdated Show resolved Hide resolved
@jmcarcell jmcarcell mentioned this pull request Feb 15, 2024
Merged
2 tasks
@jmcarcell
Copy link
Contributor

I checked and this handles well when a directory doesn't have permissions to create directories or the output file inside it: there is an error and the reason is reported

@jmcarcell jmcarcell merged commit 29fad56 into key4hep:main Mar 25, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjvbrt @jmcarcell @andresailer @tmadlener