-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show object collection name #59
Conversation
|
Hi Braulio, very nice. This doesn't address #47 yet though. What was desired there is that the bitfield is parsed to get the bits out for easier interpretation. I.e. (in python) def parse_bits(bitfield):
bits = []
# assuming here that it's a 32 bit wide number, maybe we need 64 as well?
for i in range(32):
if (bitfield & (0x1 << i)):
bits.append(i)
return bits
status = 1493172224
status_bits = parse_bits(status)
# [24, 27, 28, 30] and that could then be used to get the actual strings from this map: Lines 63 to 72 in bc2b522
For the box view we could just use the first character and then the mouse-over could have the full strings for example. |
Oh, I forgot about this, we implemented it for the filters. Thank you for explaining it again. Right now, the first character is shown on the box and the full name when mouse over, just like described above. |
js/types/objects.js
Outdated
); | ||
const simulatorStatusFirstLetter = simulatorStatus | ||
.map((s) => s[0]) | ||
.join(", "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.join(", "); | |
.join(""); |
As "explained" in the top level comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now.
based on #58
BEGINRELEASENOTES
mousemove
event has been modified, so it also checks whether the mouse is over an object. When it is, at the top of the particle, it is shown a small text, indicating the collection name to where the object belongs.ENDRELEASENOTES