Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparently introduce switch to optional param values #305

Merged
merged 1 commit into from
May 16, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Introduce pre-processor checks to transparently switch to the new std::optional return values of podio::Frame::getParameter (introduced with AIDASoft/podio#580)

ENDRELEASENOTES

@hegner
Copy link
Contributor

hegner commented May 16, 2024

@tmadlener - I think we should at the same time open a ticket to drop this after the 1.0 version is out. Do not like to accumulate these things

@tmadlener
Copy link
Contributor Author

Since this is mainly concerning one test, and the not really far spread particle id utils, I will merge this shortly, unless someone complains.

@tmadlener tmadlener merged commit 0f286fc into key4hep:main May 16, 2024
9 of 13 checks passed
@tmadlener tmadlener deleted the generic-param-optional branch May 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants