Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename type to PDG in ReconstructedParticle #273

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Rename type to PDG in ReconstructedParticle #273

merged 3 commits into from
Feb 22, 2024

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Feb 22, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Rename type to PDG in ReconstructedParticle

ENDRELEASENOTES

Fixes #146

@tmadlener
Copy link
Contributor

tmadlener commented Feb 22, 2024 •
edited
Loading

This might break a few things downstream. Checking which at the moment. The ExtraCode prevents that. What I meant to say: I am checking where deprecation warnings pop up.

@jmcarcell
Copy link
Contributor Author

Merging this one, then I can prepare the readme links for the next one...

@jmcarcell jmcarcell merged commit a4a853b into main Feb 22, 2024
18 of 19 checks passed
@jmcarcell jmcarcell deleted the typetopdg branch February 22, 2024 12:38
@jmcarcell jmcarcell mentioned this pull request Feb 22, 2024
Closed
@tmadlener
Copy link
Contributor

This is breaking FCCAnalyses in some places, e.g. here:

https://github.com/HEP-FCC/FCCAnalyses/blob/666fc8a1f68f32b7cc0ed9dea2e5781a3da87978/analyzers/dataframe/src/ReconstructedParticle.cc#L20

This was referenced Feb 22, 2024
Merged
Merged
Merged
@m-fila m-fila mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDG field in ReconstructedParticle is desirable in EIC workflows
2 participants
@jmcarcell @tmadlener