Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor III #42

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Refactor III #42

merged 9 commits into from
Aug 30, 2024

Conversation

Zehvogel
Copy link
Collaborator

@Zehvogel Zehvogel commented Jul 3, 2024

Another batch of refactoring.

BEGINRELEASENOTES

  • Reduced default output verbosities
  • Added a function to conditionally attach output converter if needed
  • Wrapped outputs to lcio and edm4hep in a generic function
  • Also adds future possibility of DST ouput for edm4hep
  • Changed default edm4hep file ending from _edm4hep.root to .edm4hep.root
  • Added configuration arguments --compactFile, --conformalTracking, --truthTracking

ENDRELEASENOTES

The edm4hep DST output will only fully work once we have key4hep/k4FWCore#226 so it is commented out for the moment.

@Zehvogel Zehvogel force-pushed the refactor branch 2 times, most recently from 22a238d to 888d47c Compare August 22, 2024 08:55
@Zehvogel Zehvogel marked this pull request as ready for review August 22, 2024 08:58
CLDConfig/py_utils.py Outdated Show resolved Hide resolved
CLDConfig/py_utils.py Outdated Show resolved Hide resolved
@Zehvogel
Copy link
Collaborator Author

I think I have applied all the suggestions

test/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@andresailer andresailer merged commit f265f3d into key4hep:main Aug 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants