-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor III #42
Merged
Merged
Refactor III #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zehvogel
force-pushed
the
refactor
branch
2 times, most recently
from
August 22, 2024 08:55
22a238d
to
888d47c
Compare
andresailer
reviewed
Aug 29, 2024
andresailer
reviewed
Aug 29, 2024
andresailer
reviewed
Aug 29, 2024
andresailer
reviewed
Aug 29, 2024
I think I have applied all the suggestions |
andresailer
reviewed
Aug 30, 2024
andresailer
reviewed
Aug 30, 2024
andresailer
reviewed
Aug 30, 2024
andresailer
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another batch of refactoring.
BEGINRELEASENOTES
_edm4hep.root
to.edm4hep.root
--compactFile, --conformalTracking, --truthTracking
ENDRELEASENOTES
The edm4hep DST output will only fully work once we have key4hep/k4FWCore#226 so it is commented out for the moment.