Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag not to always add the test directory #31

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add a flag not to always add the test directory #31

merged 2 commits into from
Jun 6, 2024

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Add a flag not to always add the test directory

ENDRELEASENOTES

Because the dependencies are different depending on whether the tests run (dd4hep, k4FWCore, k4geo, etc.) or not.

Zehvogel
Zehvogel requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Zehvogel Zehvogel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please turn them on by default or at least change the CI to still run

@jmcarcell
Copy link
Contributor Author

Done

@Zehvogel Zehvogel merged commit fdcfe54 into main Jun 6, 2024
4 of 6 checks passed
@Zehvogel Zehvogel deleted the testing branch June 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zehvogel Zehvogel Zehvogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @Zehvogel