Add wmplayer package #1740
Closed
Add wmplayer package #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoniabrahamy
force-pushed
the
wmplayer-package
branch
from
7c840a3 to
2209a07
Compare
yoniabrahamy
force-pushed
the
wmplayer-package
branch
from
2209a07 to
394f5cf
Compare
|
what? malware in mp3? is that for some exploit or what? |
|
Yeah I agree that it is very unlikely for an mp3 file to contain malware, and I'll understand if you close this PR. |
|
Os why we started to introduce filtering as we got spam of pictures on
capesandbox.com, we can't just add useless things that will waste resources
I would suggest you to start rejecting those as there is no threat
El mié, 13 sept 2023, 11:58, Jonathan Abrahamy ***@***.***>
escribió:
… Yeah I agree that it is very unlikely for an mp3 file to contain malware,
and I'll understand if you close this PR.
Some of our users are sending all kinds of files without preliminary
checks and just want to "see" the file running in the sandbox without harm.
—
Reply to this email directly, view it on GitHub
<#1740 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOFH346IJGA6LS6JF3YT2TX2F7VXANCNFSM6AAAAAA4WDUJZY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Very well, I'll close this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our users uploaded mp3 files and complained the behavior report was lacking.. so we added support for it