Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle nullable integer options #135

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Correctly handle nullable integer options #135

merged 2 commits into from
Sep 11, 2023

Conversation

Skycoder42
Copy link
Contributor

Fixes #134

@Skycoder42
Copy link
Contributor Author

Skycoder42 commented Sep 8, 2023 •
edited
Loading

Any thoughts on this? I really think this is a very important feature

@kevmoo
Copy link
Owner

kevmoo commented Sep 11, 2023

Thanks! I'd love

A new test that actually fails before the change and now succeeds
A bump to the changelog with a description of the fix!

@Skycoder42
Copy link
Contributor Author

@kevmoo Done!

@kevmoo kevmoo merged commit cadd18d into kevmoo:master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for optional integer options
2 participants
@Skycoder42 @kevmoo