Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

fix(meta): avoid meta duplication #93

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Feb 5, 2023

Resolves #70

I'd recommend not using hid or key for deduping. All meta tags will be deduped automatically for you. This also allows users to override them easily.

You can read further about the logic here: https://unhead.harlanzw.com/guide/guides/handling-duplicates

Useful to note that the key usage on <link> entries should stay

@harlan-zw harlan-zw changed the title fix(meta): allow meta to be overriden fix(meta): avoid meta duplication Feb 5, 2023
@TheAlexLichter
Copy link
Contributor

Useful to note that the key usage on entries should stay

Indeed, this is very important (see e.g. #61) so they can be deduped the right way 👍🏻

LGTM

@kevinmarrec kevinmarrec added the fix This pull request fixes an issue label Feb 5, 2023
Copy link
Owner

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@kevinmarrec kevinmarrec merged commit 772f5b8 into kevinmarrec:main Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix This pull request fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to override default tags
3 participants