forked from ampproject/amphtml
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add document fetcher (ampproject#17259)
* reverting skip * splitting util functions * bringing tests over * fixing types * fixing types * fixing types * fixing tests * making setupAMPCors as a function * resolving comments * fixing bundle-size * Update bundle-size.js * fixing presubmit * adding document fetcher * resolving comments * falling back to fetchResponse
- Loading branch information
1 parent
8500042
commit 1fe890c
Showing
2 changed files
with
288 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
/** | ||
* Copyright 2016 The AMP HTML Authors. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS-IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import {FetchResponse, assertSuccess, getViewerInterceptResponse, setupAMPCors, setupInit, setupInput, verifyAmpCORSHeaders} from './utils/xhr-utils'; | ||
import {Services} from './services'; | ||
import {user} from './log'; | ||
|
||
/** | ||
* | ||
* | ||
* @param {!Window} win | ||
* @param {string} input | ||
* @param {?./utils/xhr-utils.FetchInitDef=} opt_init | ||
* @return {!Promise<!Document>} | ||
* @ignore | ||
*/ | ||
export function fetchDocument(win, input, opt_init) { | ||
let init = setupInit(opt_init, 'text/html'); | ||
init = setupAMPCors(win, input, init); | ||
input = setupInput(win, input, init); | ||
const ampdocService = Services.ampdocServiceFor(win); | ||
const ampdocSingle = | ||
ampdocService.isSingleDoc() ? ampdocService.getAmpDoc() : null; | ||
init.responseType = 'document'; | ||
return getViewerInterceptResponse(win, ampdocSingle, input, init) | ||
.then(interceptorResponse => { | ||
if (interceptorResponse) { | ||
return interceptorResponse.text().then(body => | ||
new DOMParser().parseFromString(body, 'text/html') | ||
); | ||
} | ||
return xhrRequest(input, init).then(({xhr, response}) => { | ||
verifyAmpCORSHeaders(win, response, init); | ||
return xhr.responseXML; | ||
}); | ||
}); | ||
} | ||
|
||
/** | ||
* | ||
* | ||
* @param {string} input | ||
* @param {!./utils/xhr-utils.FetchInitDef} init | ||
* @private | ||
*/ | ||
function xhrRequest(input, init) { | ||
return new Promise((resolve, reject) => { | ||
const xhr = new XMLHttpRequest(); | ||
xhr.open(init.method || 'GET', input, true); | ||
xhr.withCredentials = (init.credentials == 'include'); | ||
xhr.responseType = 'document'; | ||
// Incoming headers are in fetch format, | ||
// so we need to convert them into xhr. | ||
for (const header in init.headers) { | ||
xhr.setRequestHeader(header, init.headers[header]); | ||
} | ||
|
||
xhr.onreadystatechange = () => { | ||
if (xhr.readyState < /* STATUS_RECEIVED */ 2) { | ||
return; | ||
} | ||
if (xhr.status < 100 || xhr.status > 599) { | ||
xhr.onreadystatechange = null; | ||
reject(user().createExpectedError( | ||
`Unknown HTTP status ${xhr.status}`)); | ||
return; | ||
} | ||
// TODO(dvoytenko): This is currently simplified: we will wait for the | ||
// whole document loading to complete. This is fine for the use cases | ||
// we have now, but may need to be reimplemented later. | ||
if (xhr.readyState == /* COMPLETE */ 4) { | ||
const response = new FetchResponse(xhr); | ||
const promise = assertSuccess(response) | ||
.then(response => ({response, xhr})); | ||
resolve(promise); | ||
} | ||
}; | ||
xhr.onerror = () => { | ||
reject(user().createExpectedError('Request failure')); | ||
}; | ||
xhr.onabort = () => { | ||
reject(user().createExpectedError('Request aborted')); | ||
}; | ||
if (init.method == 'POST') { | ||
xhr.send(/** @type {!FormData} */ (init.body)); | ||
} else { | ||
xhr.send(); | ||
} | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,186 @@ | ||
/** | ||
* Copyright 2015 The AMP HTML Authors. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS-IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import {Services} from '../../src/services'; | ||
import {fetchDocument} from '../../src/document-fetcher'; | ||
|
||
describes.realWin('DocumentFetcher', {amp: true}, function() { | ||
let xhrCreated; | ||
let ampdocServiceForStub; | ||
let ampdocViewerStub; | ||
// Given XHR calls give tests more time. | ||
this.timeout(5000); | ||
function setupMockXhr() { | ||
const mockXhr = sandbox.useFakeXMLHttpRequest(); | ||
xhrCreated = new Promise(resolve => mockXhr.onCreate = resolve); | ||
} | ||
beforeEach(() => { | ||
ampdocServiceForStub = sandbox.stub(Services, 'ampdocServiceFor'); | ||
ampdocViewerStub = sandbox.stub(Services, 'viewerForDoc'); | ||
ampdocViewerStub.returns({ | ||
whenFirstVisible: () => Promise.resolve(), | ||
}); | ||
ampdocServiceForStub.returns({ | ||
isSingleDoc: () => false, | ||
getAmpDoc: () => ampdocViewerStub, | ||
}); | ||
}); | ||
|
||
describe('#fetchDocument', () => { | ||
const win = {location: {href: 'https://acme.com/path'}}; | ||
beforeEach(() => { | ||
setupMockXhr(); | ||
}); | ||
afterEach(() => { | ||
sandbox.restore(); | ||
}); | ||
|
||
it('should be able to fetch a document', () => { | ||
const promise = fetchDocument(win,'/index.html').then(doc => { | ||
expect(doc.nodeType).to.equal(9); | ||
expect(doc.firstChild.textContent).to.equals('Foo'); | ||
}); | ||
xhrCreated.then(xhr => { | ||
expect(xhr.requestHeaders['Accept']).to.equal('text/html'); | ||
xhr.respond( | ||
200, { | ||
'Content-Type': 'text/xml', | ||
'Access-Control-Expose-Headers': | ||
'AMP-Access-Control-Allow-Source-Origin', | ||
'AMP-Access-Control-Allow-Source-Origin': 'https://acme.com', | ||
}, | ||
'<html><body>Foo</body></html>'); | ||
expect(xhr.responseType).to.equal('document'); | ||
}); | ||
return promise; | ||
}); | ||
it('should mark 400 as not retriable', () => { | ||
const promise = fetchDocument(win, '/index.html'); | ||
xhrCreated.then( | ||
xhr => xhr.respond( | ||
400, { | ||
'Content-Type': 'text/xml', | ||
'AMP-Access-Control-Allow-Source-Origin': 'https://acme.com', | ||
}, | ||
'<html></html>')); | ||
return promise.catch(e => { | ||
expect(e.retriable).to.be.equal(false); | ||
expect(e.retriable).to.not.equal(true); | ||
}); | ||
}); | ||
it('should mark 415 as retriable', () => { | ||
const promise = fetchDocument(win, '/index.html'); | ||
xhrCreated.then( | ||
xhr => xhr.respond( | ||
415, { | ||
'Content-Type': 'text/xml', | ||
'Access-Control-Expose-Headers': | ||
'AMP-Access-Control-Allow-Source-Origin', | ||
'AMP-Access-Control-Allow-Source-Origin': 'https://acme.com', | ||
}, | ||
'<html></html>')); | ||
return promise.catch(e => { | ||
expect(e.retriable).to.exist; | ||
expect(e.retriable).to.be.true; | ||
}); | ||
}); | ||
it('should mark 500 as retriable', () => { | ||
const promise = fetchDocument(win, '/index.html'); | ||
xhrCreated.then( | ||
xhr => xhr.respond( | ||
415, { | ||
'Content-Type': 'text/xml', | ||
'Access-Control-Expose-Headers': | ||
'AMP-Access-Control-Allow-Source-Origin', | ||
'AMP-Access-Control-Allow-Source-Origin': 'https://acme.com', | ||
}, | ||
'<html></html>')); | ||
return promise.catch(e => { | ||
expect(e.retriable).to.exist; | ||
expect(e.retriable).to.be.true; | ||
}); | ||
}); | ||
it('should error on non truthy responseXML', () => { | ||
const promise = fetchDocument(win, '/index.html'); | ||
xhrCreated.then( | ||
xhr => xhr.respond( | ||
200, { | ||
'Content-Type': 'application/json', | ||
'Access-Control-Expose-Headers': | ||
'AMP-Access-Control-Allow-Source-Origin', | ||
'AMP-Access-Control-Allow-Source-Origin': 'https://acme.com', | ||
}, | ||
'{"hello": "world"}')); | ||
return promise.catch(e => { | ||
expect(e.message) | ||
.to.contain('responseXML should exist'); | ||
}); | ||
}); | ||
}); | ||
describe('interceptor', () => { | ||
const origin = 'https://acme.com'; | ||
let sendMessageStub; | ||
let interceptionEnabledWin; | ||
let optedInDoc; | ||
let viewer; | ||
beforeEach(() => { | ||
setupMockXhr(); | ||
optedInDoc = window.document.implementation.createHTMLDocument(''); | ||
optedInDoc.documentElement.setAttribute('allow-xhr-interception', ''); | ||
ampdocServiceForStub.returns({ | ||
isSingleDoc: () => true, | ||
getAmpDoc: () => ({getRootNode: () => optedInDoc}), | ||
}); | ||
viewer = { | ||
hasCapability: () => true, | ||
isTrustedViewer: () => Promise.resolve(true), | ||
sendMessageAwaitResponse: getDefaultResponsePromise, | ||
whenFirstVisible: () => Promise.resolve(), | ||
}; | ||
sendMessageStub = sandbox.stub(viewer, 'sendMessageAwaitResponse'); | ||
sendMessageStub.returns(getDefaultResponsePromise()); | ||
ampdocViewerStub.returns(viewer); | ||
interceptionEnabledWin = { | ||
location: { | ||
href: `${origin}/path`, | ||
}, | ||
Response: window.Response, | ||
}; | ||
}); | ||
function getDefaultResponsePromise() { | ||
return Promise.resolve({init: getDefaultResponseOptions()}); | ||
} | ||
function getDefaultResponseOptions() { | ||
return { | ||
headers: [ | ||
['AMP-Access-Control-Allow-Source-Origin', origin], | ||
], | ||
}; | ||
} | ||
it('should return correct document response', () => { | ||
sendMessageStub.returns( | ||
Promise.resolve({ | ||
body: '<html><body>Foo</body></html>', | ||
init: { | ||
headers: [['AMP-Access-Control-Allow-Source-Origin', origin]], | ||
}, | ||
})); | ||
return fetchDocument(interceptionEnabledWin, 'https://www.some-url.org/some-resource/').then(doc => { | ||
expect(doc).to.have.nested.property('body.textContent') | ||
.that.equals('Foo'); | ||
}); | ||
}); | ||
}); | ||
}); |