Skip to content

Commit

Permalink
Completely redesign pagination code, support backwards pagination upo…
Browse files Browse the repository at this point in the history
…n scroll

Remove the separate pagination state subscriber task, which was previously
being spawned once for every room. That was unnecessary and actually provided
less information than just waiting for the result of the original task
that actually called the paginate function.

Store the most-recently-scrolled-through item index in `TimelineUiState`
such that we can determine whether when the user is scrolling upwards
and has just hit the top-most item, at which point we fire off
a backwards pagination request.
  • Loading branch information
kevinaboos committed Oct 12, 2024
1 parent 18237da commit 9bc6f35
Show file tree
Hide file tree
Showing 5 changed files with 252 additions and 202 deletions.
93 changes: 57 additions & 36 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ metadata.makepad-auto-version = "zqpv-Yj-K7WNVK2I8h5Okhho46Q="

[dependencies]
# makepad-widgets = { git = "https://github.com/makepad/makepad", branch = "rik" }
makepad-widgets = { git = "https://github.com/kevinaboos/makepad", branch = "apple_bundle_resource_path" }
makepad-widgets = { git = "https://github.com/kevinaboos/makepad", branch = "portal_list_ref_immut_self" }


## Including this crate automatically configures all `robius-*` crates to work with Makepad.
robius-use-makepad = "0.1.0"
robius-open = "0.1.0"
robius-open = "0.1.1"
## A fork of the `directories` crate that adds support for Android by using our `robius-android-env` crate.
robius-directories = { git = "https://github.com/project-robius/robius-directories", branch = "robius"}
robius-location = { git = "https://github.com/project-robius/robius-location" }
Expand Down
Loading

0 comments on commit 9bc6f35

Please sign in to comment.