considering in-call status bar frame changes

[hardikdevios]

First of all Great Lib and now it will be a part of my default Pods

All things are great just one thing and it might not be an issue with Lib because i have not explore the lib that much.

Issue or suggestion

considering in-call status bar frame changes

Now i am setting the height of contentSizeInPopup in this way and it works awesome with dynamic height

override func viewDidLoad() {
        super.viewDidLoad()
        self.tableView.addObserver(self, forKeyPath: "contentSize", options: NSKeyValueObservingOptions.New, context: nil)
        self.contentSizeInPopup = CGSizeMake(UIScreen().bounds.width, self.tableView.contentSize.height ?? 200)

  }

    override func observeValueForKeyPath(keyPath: String?, ofObject object: AnyObject?, change: [String : AnyObject]?, context: UnsafeMutablePointer<Void>) {
        guard let _ = self.tableView else {
            return
        }
        self.contentSizeInPopup = CGSizeMake(UIScreen().bounds.width, self.tableView.contentSize.height ?? 200)

    } 

But during the in-call status bar where the size of status bar increased with 40px, At that time popup got shifts down with 20px and was not able to scroll to the bottom of the last cell. so what is the better way to handle this ? any help, Thanks in advanced.

[kevin-lyn]

@hardikdevios Thanks!
Actually there is a bug when in-call status bar is showed when popup controller is presented. But in your case, think you can try observing UIApplicationDidChangeStatusBarFrameNotification and get the new frame of status bar before setting new contentSizeInPopup.

[hardikdevios]

@kevin0571 yes mate i have put that observer and solved issue but thanks for your response. any chance of fixes in the main repo ?

[kevin-lyn]

@hardikdevios I will try to fix the in-call status bar issue. PR is welcome.

[hardikdevios]

Any update on this ?

[kevin-lyn]

@hardikdevios I just pushed a fix to master. Let me know if the issue is still there.

[hardikdevios]

please add tag and update podspac

[hardikdevios]

Well issue is fixed cheers buddy. 👍

[kevin-lyn]

Cool! Will release a version after I fix another issue. Meanwhile, you could point to HEAD in your Podfile.

Sent from my iPhone

On 2 Aug 2016, at 02:45, Hardik <[email protected]mailto:[email protected]> wrote:

Well issue is fixed cheers buddy. ?

You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com//issues/62#issuecomment-236670078, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABbBUsZQfFwXJ-9Fjf4H8spBXxtTRlREks5qbj7UgaJpZM4IQ6j-.