Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: switch to translations coming from config and fix UI inconsistencies #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ArmchairAllStar
Copy link
Contributor

  • Switch to translations coming from config
  • fix UI inconsistencies

Description of this change

These changes are being made to reduce the number of calls being made and reduce complexity on figuring out what text should be used. There are also changes being made to the UI to better reflect existing state within Ketch Tag.

Why is this change being made?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

Tested locally

Related issues

NA

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant