Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Access.md #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Access.md #27

wants to merge 1 commit into from

Conversation

hbarnstone
Copy link

Description of this change

Description here

Why is this change being made?

  • Chore (non-functional changes)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

Related issues

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

@@ -97,7 +97,7 @@ specified in the request.
The `results` and `documents` are merged with any cached results from previous events. New documents are
added and existing documents are updated.

Once the status is set to `completed`, `cancelled` or `denied`, then no further events will be accepted.
Once the status is set to `completed`, `in_progress` or `pending`, then no further events will be accepted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I think that once the status is set to completed then no further events would be accepted. But for in_progress and pending statuses, the API call tile expects a callback, correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prachikhandekar what is the difference between 'in progress' and 'pending" I have only ever sent back "in progress' or "completed".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the backend code treats them the exact same. So they are both "valid" statuses that behave the exact same way in our backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants