Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix token permissions in ci.yml #25

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

dane-kk
Copy link
Contributor

@dane-kk dane-kk commented Oct 11, 2024

Description of this change

fix token permissions in ci.yml

Why is this change being made?

  • Chore (non-functional changes)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

n/a

Related issues

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

Copy link

@hanpeter hanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the permission and merge. No need for another review.

dockerfile: docker/ketch-event-forwarder/Dockerfile
fail-fast: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
permissions:
contents: read
contents: write

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contents: write
contents: read

IIRC, contents: write means you are committing to this repository. We don't need that permission.

@dane-kk dane-kk merged commit 904959e into main Oct 11, 2024
5 checks passed
@dane-kk dane-kk deleted the dane-kk/chore/update-deps_permissions branch October 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants