Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Style Tab & Connex - open external link bug #303

Open
rdewolff opened this issue Feb 22, 2019 · 7 comments
Open

Tree Style Tab & Connex - open external link bug #303

rdewolff opened this issue Feb 22, 2019 · 7 comments
Labels

Comments

@rdewolff
Copy link

After a fresh Firefox install, if I install Connex and Tree Style Tab plugin, I cannot open external clicked links.

When I click a link in another program, Firefox gets the focus, opens the tab, and closes the tab. All this very quickly.

Could you check this please?

@kesselborn
Copy link
Owner

what are your settings regarding "ask in which container to open external links instead of always using the current container"?

@rdewolff
Copy link
Author

Just a note: if I disable Conex, the issue does not happen anymore.

@rdewolff
Copy link
Author

what are your settings regarding "ask in which container to open external links instead of always using the current container"?

I have tried both settings, and they both do not work.

@kesselborn
Copy link
Owner

kesselborn commented Feb 22, 2019 via email

@piroor
Copy link

piroor commented Mar 4, 2019

After testing I've realized why this happens on a case.
https://github.com/kesselborn/conex/blob/master/conex-background.js#L467
Conex tries to open a new tab as a "child" of the original tab, and immediately closes the "parent" tab after the child is opened. On the other hand, TST automatically attaches the new "child" tab to the "parent", but its tree is internally still collapsed. Because the "parent" tab is closed before it becomes expanded, TST closes all children in the collapsed tree.

I think this problem must be fixed by TST side.

@rdewolff
Copy link
Author

rdewolff commented Mar 4, 2019

Thanks for the answer @piroor. I have updated the ticket piroor/treestyletab#2162 and added your feedback.
Let's hope someone can fix it🤞

@piroor
Copy link

piroor commented Mar 4, 2019

This problem should be fixed by the commit: piroor/treestyletab@2233374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants