Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification issue on gnome shell + minor improvements #202

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

keshavbhatt
Copy link
Owner

  • apply hack to make notification appear on gnome shell
  • minor improvements on notification click handling
  • clicking native notification now takes user to message

closes #198 #161 #121

- apply hack to make notification appear on gnome shell
- minor improvements on notification click handling
@keshavbhatt keshavbhatt merged commit 86f27b9 into main Oct 19, 2024
2 checks passed
@Arche151
Copy link

Arche151 commented Oct 22, 2024

@keshavbhatt Unfortunately, the native notification issue hasn't been fixed with 4.16.1 :(

When I get a message, I do get a native notification from WhatSie (albeit with a red exlamation mark as icon, instead of the WhatSie icon), but when I click on the notifcation, WhatSie simply crashes and closes.

This is the message that appears in the terminal when that occurs: qt.qpa.wayland: Wayland does not support QWindow::requestActivate()

I would reeally appreciate, if you could take a look at this issue and I thank you a lot for all the work you put in WhatSie!

I am on Ubuntu 22.04 (Wayland).

@keshavbhatt
Copy link
Owner Author

@Arche151 it must be fixed in 14.6.2 please update and confirm.
I tested using latest snap package and it no more crashes.

@Arche151
Copy link

Arche151 commented Oct 26, 2024

@keshavbhatt Thanks for the update! I updated to the 4.6.2 snap but now when I get a WhatsApp message, while Whatsie is minimzed, I don't get a notification and Whatsie simply crashes.

Here are the logs:

Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
/usr/share/libdrm/amdgpu.ids: No such file or directory
amdgpu: unknown (family_id, chip_external_rev): (148, 10)
libGL error: failed to create dri screen
libGL error: failed to load driver: radeonsi
Qt: Session management error: Could not open network socket
propsReply "An AppArmor policy prevents this sender from sending this message to this recipient; type=\"method_call\", sender=\":1.629\" (uid=1000 pid=329313 comm=\"/snap/whatsie/163/usr/bin/whatsie \" label=\"snap.whatsie.whatsie (enforce)\") interface=\"org.freedesktop.DBus.Properties\" member=\"GetAll\" error name=\"(unset)\" requested_reply=\"0\" destination=\"org.freedesktop.NetworkManager\" (uid=0 pid=1375 comm=\"/usr/sbin/NetworkManager --no-daemon \" label=\"unconfined\")"
nmReply "An AppArmor policy prevents this sender from sending this message to this recipient; type=\"method_call\", sender=\":1.629\" (uid=1000 pid=329313 comm=\"/snap/whatsie/163/usr/bin/whatsie \" label=\"snap.whatsie.whatsie (enforce)\") interface=\"org.freedesktop.NetworkManager\" member=\"GetDevices\" error name=\"(unset)\" requested_reply=\"0\" destination=\"org.freedesktop.NetworkManager\" (uid=0 pid=1375 comm=\"/usr/sbin/NetworkManager --no-daemon \" label=\"unconfined\")"
"Object path cannot be empty"
Segmentation fault (core dumped)

The line Segmentation fault (core dumped) appears after the crash, all other lines appear already when launching Whatsie. After the crash, when re-opening Whatsie, I am also logged out of WhatsApp again.

Hope that helps pinpointing the issue.

@robertvb
Copy link

hi, issue still happening on 4.16.3 (flatpak)

env:
GNOME 43.9
X11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification doesn't appear on Ubuntu 24.04 LTS when using the Native option
3 participants