Skip to content

Commit

Permalink
[chore] optimize code style (apache#2000)
Browse files Browse the repository at this point in the history
Signed-off-by: yuluo-yx <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
  • Loading branch information
yuluo-yx and tomsun28 authored May 18, 2024
1 parent 2d925eb commit d6d6d3c
Show file tree
Hide file tree
Showing 19 changed files with 23 additions and 25 deletions.
2 changes: 1 addition & 1 deletion hip/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,4 @@ It is advised to create a master GitHub issue to formulate the execution plan an
- Merged PR means the HIP was accepted.
- Closed PR means the HIP was rejected.
- Open PR means the HIP was submitted and is in the process of discussion.
2. You can also take a look at the file in the `hip` folder. Each one is an approved HIP.
2. You can also take a look at the file in the `hip` folder. Each one is an approved HIP.
2 changes: 1 addition & 1 deletion hip/TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,4 @@ If there are alternatives that were already considered by the authors or, after
Updated afterwards
-->
* Mailing List discussion thread:
* Mailing List voting thread:
* Mailing List voting thread:
2 changes: 1 addition & 1 deletion hip/hip-01.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ Supplement the relevant unit tests.
Updated afterwards
-->
* Mailing List discussion thread: https://lists.apache.org/thread/cvvo7xg35fxq7kml5ggdrcdygrx6yvyj
* Mailing List voting thread: https://lists.apache.org/thread/1s7dhrb27qfdx1gsh29dvmo8frjbt619
* Mailing List voting thread: https://lists.apache.org/thread/1s7dhrb27qfdx1gsh29dvmo8frjbt619
5 changes: 2 additions & 3 deletions plugin/src/main/java/org/apache/hertzbeat/plugin/Plugin.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/


package org.apache.hertzbeat.plugin;

import org.apache.hertzbeat.common.entity.alerter.Alert;
Expand All @@ -25,8 +24,8 @@
*/
public interface Plugin {

/*
* execute when alert
/**
* execute when alert
*/
void alert(Alert alert);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/


package org.apache.hertzbeat.plugin.impl;

import lombok.extern.slf4j.Slf4j;
Expand All @@ -27,11 +26,13 @@
*/
@Slf4j
public class DemoPluginImpl implements Plugin {
/*
* execute when alert

/**
* execute when alert
*/
@Override
public void alert(Alert alert) {
log.info("DemoPluginImpl alert: {}", alert);
}

}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
org.apache.hertzbeat.plugin.impl.DemoPluginImpl
org.apache.hertzbeat.plugin.impl.DemoPluginImpl
2 changes: 1 addition & 1 deletion push/src/main/resources/META-INF/spring.factories
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# limitations under the License.

org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
org.apache.hertzbeat.push.config.PushAutoConfiguration
org.apache.hertzbeat.push.config.PushAutoConfiguration
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,9 @@ public interface RemotingServer extends RemotingService {
*/
ClusterMsg.Message sendMsgSync(Channel channel, ClusterMsg.Message request, int timeoutMillis);

/**
* register hook.
* @param nettyHookList hook list
*/
void registerHook(List<NettyHook> nettyHookList);
}
1 change: 0 additions & 1 deletion script/docker/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,4 @@ $ docker buildx build --platform linux/arm64,linux/amd64 -t quay.io/tancloud/her

# Inspect the image info
$ docker buildx imagetools inspect apache/hertzbeat:v1.0.0

```
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

package org.apache.hertzbeat.warehouse.dao;


import org.apache.hertzbeat.common.entity.warehouse.History;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@
import org.springframework.context.event.EventListener;
import org.springframework.stereotype.Component;



/**
*
* WareHouseApplicationReadyListener
*/
@Slf4j
@Component
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.apache.hertzbeat.common.entity.dto.Value;

/**
*
* history data reader
*/
public interface HistoryDataReader {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.apache.hertzbeat.common.entity.message.CollectRep;

/**
*
* history data writer
*/
public interface HistoryDataWriter {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

package org.apache.hertzbeat.warehouse.store.history.vm;


import com.fasterxml.jackson.databind.JsonNode;
import java.math.BigDecimal;
import java.math.RoundingMode;
Expand Down Expand Up @@ -59,7 +58,6 @@
import org.springframework.web.client.RestTemplate;
import org.springframework.web.util.UriComponentsBuilder;


/**
* tdengine data storage
*/
Expand Down
2 changes: 1 addition & 1 deletion warehouse/src/main/resources/META-INF/spring.factories
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# limitations under the License.

org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
org.apache.hertzbeat.warehouse.WarehouseAutoConfiguration
org.apache.hertzbeat.warehouse.WarehouseAutoConfiguration
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ void getCurrentMetricsData() {
@Test
void destroy() {
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ void encodeKey() {
@Test
void encodeValue() {
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ void getCurrentMetricsData() {
@Test
void destroy() {
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@ void getHistoryMetricData() {
@Test
void getHistoryIntervalMetricData() {
}
}
}

0 comments on commit d6d6d3c

Please sign in to comment.