Further enhance and refine the optimizations implemented in apache#2215.

kerwin612 · Jul 9, 2024 · 96c4194 · 96c4194
1 parent f90d1e6
commit 96c4194
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
@@ -59,7 +59,7 @@
       </ng-container>
 
       <nz-collapse
-        *ngIf="advancedParamDefines && advancedParamDefines.length > 0"
+        *ngIf="hasAdvancedParams"
         [nzGhost]="true"
         style="background: ghostwhite; margin-bottom: 24px"
       >

diff --git a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { Component, EventEmitter, Input, Output } from '@angular/core';
+import { Component, EventEmitter, Input, Output, OnChanges, SimpleChanges } from '@angular/core';
 import { FormGroup } from '@angular/forms';
 
 import { Collector } from '../../../pojo/Collector';
@@ -29,7 +29,7 @@ import { ParamDefine } from '../../../pojo/ParamDefine';
   templateUrl: './monitor-form.component.html',
   styleUrls: ['./monitor-form.component.less']
 })
-export class MonitorFormComponent {
+export class MonitorFormComponent implements OnChanges {
   @Input() monitor!: any;
   @Input() loading!: boolean;
   @Input() loadingTip!: string;
@@ -46,8 +46,21 @@ export class MonitorFormComponent {
   @Output() readonly formDetect = new EventEmitter<any>();
   @Output() readonly hostChange = new EventEmitter<string>();
 
+  hasAdvancedParams: boolean = false;
+
   constructor() {}
 
+  ngOnChanges(changes: SimpleChanges) {
+    if (changes.advancedParams && changes.advancedParams.currentValue !== changes.advancedParams.previousValue) {
+      for (const advancedParam of changes.advancedParams.currentValue) {
+        if (advancedParam.display !== false) {
+          this.hasAdvancedParams = true;
+          break;
+        }
+      }
+    }
+  }
+
   onDetect(formGroup: FormGroup) {
     if (formGroup.invalid) {
       Object.values(formGroup.controls).forEach(control => {