Update to branch-heads/64 #79
Conversation
Currently at commit 88f5d9180eae78a6162cccd78850ff416eb82483. The biggest change is that header files are no longer in a webrtc/ subdirectory. Here is the upstream change: https://webrtc.googlesource.com/src/+/bb547203bfebcc478b263c4e9ca173c6fd5a0c5d The signatures for PeerConnectionObserver and CreatePeerConnectionFactory are slightly changed. I took the examples of CreateBuiltinAudioEncoderFactory and CreateBuiltinAudioDecoderFactory from https://chromium.googlesource.com/external/webrtc/+/32df86ee0e1d892223f6915cd39ab9cb026d9695 This version of WebRTC seems to prefer to link with a bundled copy of libc++ (libcxx) by default. We set use_custom_libcxx=false in order to link with libstdc++ like before. The build automatically used the c++11 ABI, such that I got link errors (e.g. "undefined reference to `webrtc::JsepSessionDescription::JsepSessionDescription(std::string const&)'"). So remove the manual setting of _GLIBCXX_USE_CXX11_ABI=0 in .pc files.
This is from a build.sh of linux-amd64. build.sh has a "git clean" command that wiped out the automatically copied files, so I re-ran the copy loop manually. I omitted the build, buildtools, third_party, and tools directories.
|
Hmm, I would expect the Linux part of this to be passing in CI, no? In order to get the macOS build working, I neeeded 99f5639 but the magic is now in 9be426d For the |
|
Oh thanks—I didn't think about CI. All the undefined references seem to reference things like Regarding 99f5639, I found the same Thanks for the .gitignore on include/. I noticed that there were seemingly too many subdirectories, but I didn't know that the correct ones had already been enumerated. |
In order to do this, I had to hack defines += [ "_GLIBCXX_USE_CXX11_ABI=0" ] into build/config/BUILD.gn.
Ok, I added similar in e45d138
I reverted that part since we're still providing a library here with the old ABI. I briefly tried setting |
I opened #81 for figuring this out. The bulk of this is now merged though. Thanks! |
I'm not sure if you want to take this yet or not. In working on cross-compiling support go-webrtc for Windows, I needed to upgrade to branch-heads/64 for the new cross-compiling support.
I'm basing my Windows changes on this branch and it works so far, producing a webrtc.lib as well as continuing to be able to build snowflake for mac and linux.
The substantive part of the change is 371aaf6; the other commits are just generated headers and libraries. Those are for your reference, and don't necessarily have to be merged as-is. I expect you'll want to generate those yourself anyway. I don't have the hardware to generate libwebrtc-darwin-amd64-magic.a.