Add support for sending and receiving audio, and all that entails. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damageless
approved these changes
May 24, 2017
Open
|
Any progress on this? I am ready to start putting in more A/V support, and I would prefer to go with this approach if it is approved. |
It seems reasonable but I haven't looked at it in too much detail. Suffice it to say, it's probably safe to build on. |
|
I've been working on a new project based on this and it's been working well so far. I'll see if I can clean up some of the code and contribute back to this. |
|
Any updates on this PR? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation for implementing this only included receiving and sending audio (as a back-end service would do), not recording or playing audio from/to microphone and speakers (as a front-end app might). Therefore, I stuck with a fake AudioDeviceModule [0]. Down the road, it might be desirable to allow real AudioDeviceModules.
addresses #7
[0] Another reason for using a fake AudioDeviceModule was so I could disable its capture and push of audio, which audio ended up being interleaved with the audio from sent tracks, corrupting it on the receiving end. There must be a better way to fix this, but I couldn't find it.