Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to PPC64 #191

Merged
merged 3 commits into from
Jun 9, 2015
Merged

Port to PPC64 #191

merged 3 commits into from
Jun 9, 2015

Conversation

gut
Copy link
Contributor

@gut gut commented Jun 9, 2015

I just updated Turbolua to be able to run also on POWER architecture 64 bits.

Our team is still finishing the LuaJIT port to PPC64 so it's not on the official repository yet. Take a look at our Wiki hosted on GitHub for the latest status and for our code, if you want to check:
https://github.com/LuaJIT-PPC64/LuaJIT-PPC64/tree/ppc64-port

That LuaJIT is already functional and on Turbolua I was able to run some examples like the chatapp. If you have more tests that we can run on our PPC64 machine in order to find possible bugs, give us a hint please.

gut added 3 commits June 9, 2015 13:56
It's correctly used on turbo/cdef.lua
LuaJIT is being ported to PPC64 and turbolua is being tested to support
it.
The define __PPC64__ is defined based on GCC flags on a POWER8 system:
$ uname -m
 ppc64le

$ gcc -E -dM - < /dev/null | grep PPC
 #define _ARCH_PPCGR 1
 #define __PPC64__ 1
 #define _ARCH_PPCSQ 1
 #define _ARCH_PPC 1
 #define __PPC__ 1
 #define _ARCH_PPC64 1
And as PPC64 is __ABI64__, I had to change the condition to force usage
of __ABI32__ on PPC64 case.
@kernelsauce
Copy link
Owner

Tests are done pretty simple with make test.

Make sure that you have busted installed...

kernelsauce added a commit that referenced this pull request Jun 9, 2015
@kernelsauce kernelsauce merged commit 4b8d575 into kernelsauce:master Jun 9, 2015
@gut
Copy link
Contributor Author

gut commented Jun 10, 2015

it took a while (20 minutes) and it didn't finish as expected:
$ make test
==== Running tests for Turbo.lua. NOTICE: busted module is required ====
export LD_LIBRARY_PATH=/usr/local/lib; export TURBO_TEST_SSL=1; busted
●●●●●●●●●●●[S 2015/06/09 17:07:50] [web.lua] 200 OK GET / (127.0.0.1) 0ms
[S 2015/06/09 17:07:50] [async.lua] GET 127.0.0.1:31835/ => 200 OK 1ms
●●●●●●●●●●●●●●●●Killed
make: *** [test] Error 137

Any comments on this? Might be something else that I failed on porting...

@gut
Copy link
Contributor Author

gut commented Jun 10, 2015

got it... it's the spec/iostream_spec.lua that is blocking. I'll check it closely and come back with news...

@kernelsauce
Copy link
Owner

Probably is the big read and writes. They can take a while but should
definately succeed.

ons. 10. jun. 2015 kl. 13.44 skrev Gustavo Serra Scalet <
[email protected]>:

got it... it's the spec/iostream_spec.lua that is blocking. I'll check it
closely and come back with news...


Reply to this email directly or view it on GitHub
#191 (comment).

@gut
Copy link
Contributor Author

gut commented Jun 10, 2015

well, after reducing the number of "bytes:append_luastr_right" calls it worked:
59 successes / 0 failures / 0 errors / 0 pending : 11.334306 seconds

Thanks

@gut gut deleted the ppc64-port branch June 10, 2015 14:16
@kernelsauce
Copy link
Owner

Good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants