-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update discovery.md on mDNS Information #786
Conversation
67da91d
to
f520721
Compare
f520721
to
49d2e99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments I'd like you to address before we merge this.
First, I'd really like to see the netbrowse section at the very beginning of this document. The document will come to life quicker with the nice picture of of the browser showing a listing of multiple devices.
Additionally, I'd like you to overhaul the whole page to not use the default Qemu MAC address (00-00-00) and instead use something else, e.g., c0-ff-ee or similar that we use elsewhere. Check with J-O for good examples.
Also, a representative example for netbrowse would be to have more than one device in the listing, at least one more, and use a different hostname than the default -- because that's one of the first things an administrator changes. Again, check with J-O for good name examples, we use descriptive names in the tests so should we here in the docs.
Plenty of commits. :-/ |
Add information about: - mDNS alias - https://network.local [skip ci] Fixes #738
Use infix-c0-ff-ee (or similar) rather than infix-00-00-00 Adapting picture and text for netbrowse function to use more than on unit [skip ci]
- Adding info on how to disable LLDP - Avoiding clickable URL to https://network.local [skip ci]
Changing title on the section on netbrowse service [skip ci]
Use proposal from review. [skip ci]
c887d41
to
d277f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Additional documentation on netbrowse can be added later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add information about:
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: