lava_callback.py: Extend /checkout endpoint functionality #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
extend-checkout-functionality
branch
from
13e02fa
to
b8ac3f2
Compare
nuclearcat
force-pushed
the
extend-checkout-functionality
branch
4 times, most recently
from
3582cb2
to
33fc8ea
Compare
Before user can use reference nodeid and custom commitid to submit custom checkout node. Now we allow also user to submit tree information and jobfilter, but all this data will be validated in config, e.g. user can submit tree that only exist in pipeline configs, job names that exist in jobs: and etc. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
extend-checkout-functionality
branch
from
33fc8ea
to
40169ae
Compare
As no job filter set cause quite significant load, and way longer processing make sure it is not missing by mistake. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
extend-checkout-functionality
branch
from
2898d82
to
b574870
Compare
|
Tested on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before user can use reference nodeid and custom commitid to submit custom checkout node.
Now we allow also user to submit tree information and jobfilter, but all this data will be validated in config, e.g. user can submit tree that only exist in pipeline configs, job names that exist in jobs: and etc.