Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyboard shortcuts #137

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Update keyboard shortcuts #137

merged 3 commits into from
Jun 14, 2021

Conversation

alexandrasp
Copy link

No description provided.

@alexandrasp alexandrasp requested a review from a team April 1, 2021 03:40
@alexandrasp alexandrasp mentioned this pull request Apr 1, 2021
Open
@alexandrasp alexandrasp changed the base branch from main to staging.kernelci.org April 1, 2021 14:02
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch 3 times, most recently from 3e5373b to 3a7a242 Compare April 1, 2021 15:00
@alexandrasp alexandrasp changed the base branch from staging.kernelci.org to main April 1, 2021 15:01
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch from 3a7a242 to de14e17 Compare April 1, 2021 17:54
@alexandrasp alexandrasp changed the base branch from main to staging.kernelci.org April 1, 2021 18:00
@alexandrasp alexandrasp changed the base branch from staging.kernelci.org to main April 1, 2021 18:00
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch 3 times, most recently from 754f183 to 6ccc8aa Compare April 2, 2021 05:34
@alexandrasp alexandrasp changed the base branch from main to staging.kernelci.org April 2, 2021 05:40
@alexandrasp alexandrasp changed the base branch from staging.kernelci.org to main April 2, 2021 05:40
@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Apr 2, 2021
@alexandrasp alexandrasp changed the base branch from main to staging.kernelci.org April 2, 2021 14:00
@alexandrasp alexandrasp changed the base branch from staging.kernelci.org to main April 2, 2021 14:01
@alexandrasp alexandrasp removed the staging-skip Don't test automatically on staging.kernelci.org label Apr 2, 2021
@alexandrasp
Copy link
Author

alexandrasp commented Apr 2, 2021 •
edited
Loading

Tested OK on staging.
Boot icons removed, key shortcut is back on info page and test page now has its own key shortcut (g+t) .

@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Apr 3, 2021
@gctucker
Copy link
Contributor

gctucker commented Apr 3, 2021

It's causing some views to not work, for example this one is not loading any test results:
https://staging.kernelci.org/test/job/next/branch/master/kernel/next-20210322/plan/baseline/

It works again with this PR skipped. Please test it locally to debug the issue.

Alexandra Pereira added 2 commits May 16, 2021 21:09
dashboard/templates: update symbols legend
de56846 
remove symbols legends used for boots and compare.

Signed-off-by: Alexandra Pereira <[email protected]>
dashboard/templates: update keyboard shortcuts
5cd65e6 
Delete shotcuts to boot and compare views and add a shortcut
to tests view.

Signed-off-by: Alexandra Pereira <[email protected]>
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch from 6ccc8aa to d265b39 Compare May 17, 2021 02:52
@alexandrasp alexandrasp removed the staging-skip Don't test automatically on staging.kernelci.org label May 17, 2021
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch 3 times, most recently from f936455 to 088ea84 Compare May 18, 2021 05:57
@gctucker
Copy link
Contributor

Still causing the same issue: https://staging.kernelci.org/test/job/kernelci/branch/staging-stable/kernel/staging-stable-20210518.0/plan/baseline/

Adding skip tag for now.

@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label May 18, 2021
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch 2 times, most recently from 437d133 to 9ac94f2 Compare June 1, 2021 02:10
@alexandrasp alexandrasp removed the staging-skip Don't test automatically on staging.kernelci.org label Jun 1, 2021
@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Jun 1, 2021
@gctucker
Copy link
Contributor

gctucker commented Jun 1, 2021

@alexandrasp This is still causing some issues on the page with the test plan results.

dashboard: update keyboard shortcuts scripts
ec11348 
add a new script to info view in order to keep shortcuts
working and switch boot option to test view.

Signed-off-by: Alexandra Pereira <[email protected]>
@alexandrasp alexandrasp force-pushed the update-keyboard-shortcuts branch from 9ac94f2 to ec11348 Compare June 9, 2021 14:32
@alexandrasp alexandrasp removed the staging-skip Don't test automatically on staging.kernelci.org label Jun 9, 2021
@alexandrasp
Copy link
Author

@gctucker finally is working. Could take a look ? So I can merge this PR.

@gctucker
Copy link
Contributor

@alexandrasp No it's not, this page keeps spinning for ever: https://staging.kernelci.org/test/plan/id/60c30893aa0897fc72c6cbed/

Again, have you actually reproduced the issue locally and made a fix? And if so, what was the fix?

I need to put the staging-skip label again as we can't see results on the staging frontend otherwise.

@gctucker gctucker added staging-skip Don't test automatically on staging.kernelci.org and removed staging-skip Don't test automatically on staging.kernelci.org labels Jun 11, 2021
@gctucker
Copy link
Contributor

OK sorry it seems to be working now, I've removed the skip label again. I think there was a problem just with the page I was looking at.

Still, what was the issue?

@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Jun 11, 2021
@gctucker
Copy link
Contributor

There's also an issue here, even with this PR skipped (so it's another kind of issue):
https://staging.kernelci.org/test/plan/id/60c32001c97befa838c6cc0c/

@gctucker gctucker removed the staging-skip Don't test automatically on staging.kernelci.org label Jun 11, 2021
gctucker
gctucker approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK on staging.

@gctucker gctucker merged commit 0b419ed into kernelci:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gctucker gctucker gctucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrasp @gctucker