Experimental command to fetch results from the Dashboard API

[padovan]

Add PoC for kci-dev results from the Dashboard API.

See the docs/results.md for details about this command. For the time being, it will be experimental as we refine how together with kernel developers how they are going to be using kci-dev.

There is a know slowdown in the API due to kernelci/dashboard#661.

Related to #57

[aliceinwire]

LGTM
I'm ok to merge this as experimental function, we can update it after.

[robherring]

I gave it try and have a few random comments. (Not expecting all these in this PR)

I guess getting 'latest' build is dependent on the API change.

It would be nice if --commit value could be passed thru git-rev-parse so that symbolic and short commit hashes worked. That assumes you are sitting in a tree that can resolve them, so it would have to be optional. That would effectively provide a way to get the latest as well. Probably should throw an error if the commit hash isn't found. Currently it's just 0 builds, boots, tests.

I think I would make '--action' be a sub-sub-command (e.g. kci-dev results failed-build ...).

We need to be able to get successful build logs too if we want to see warnings, right? Parsed warning summaries like the dashboard are nice too.

The log names need the compiler used too or you will get name collisions.

Supporting a config file to store the giturl and branch would be nice. One way to do that is hijacking .gitconfig with your own section. This is what the b4 utility does.

[broonie]

Supporting a config file to store the giturl and branch would be nice. One way to do that is hijacking .gitconfig with your own section. This is what the b4 utility does.

Getting the giturl from the configured git remotes seems like a good idea in general, separately to the branch (ie, do what git does and try the supplied URL as both a literal URL and an alias configured in .git/config).

[padovan]

Thanks for you comments @robherring and @broonie

I guess getting 'latest' build is dependent on the API change.

I believe we have that in the API yet. I'll add a task to look into that after we merge this PR

It would be nice if --commit value could be passed thru git-rev-parse so that symbolic and short commit hashes worked. That assumes you are sitting in a tree that can resolve them, so it would have to be optional. That would effectively provide a way to get the latest as well. Probably should throw an error if the commit hash isn't found. Currently it's just 0 builds, boots, tests.

Yeah. Good point. Will add a task for it as well.

I think I would make '--action' be a sub-sub-command (e.g. kci-dev results failed-build ...).

Indeed. It is my goal. But I am struggling to understand how python click does that...so I decided to focus on adding value to users like you first rather than deep diving on python machinery.

We need to be able to get successful build logs too if we want to see warnings, right? Parsed warning summaries like the dashboard are nice too.

I have to check how we handle warnings in KCIDB and Web Dashboard. This would be the lowest priority from all your comments.

The log names need the compiler used too or you will get name collisions.

Fixed in this PR.

Supporting a config file to store the giturl and branch would be nice. One way to do that is hijacking .gitconfig with your own section. This is what the b4 utility does.

Awesome idea. Thanks for this suggestion!

[aliceinwire]

please resolve conflicts with main.py

[padovan]

@aliceinwire I have this

reformatted /home/gus/p/ecosystem/kci-dev/kcidev/main.py

All done! ✨ 🍰 ✨
1 file reformatted, 12 files left unchanged.
Fixing /home/gus/p/ecosystem/kci-dev/kcidev/main.py

But no changes are generated:

(.venv) poutine kci-dev > git diff
(.venv) poutine kci-dev > git status 
On branch experimental-results-fetching
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	kcidev/full-next-results.json
	kcidev/subcommands/analyze-dashboard-json.py

nothing added to commit but untracked files present (use "git add" to track)

so I don't know how to make the pipeline green :(

[aliceinwire]

@aliceinwire I have this

reformatted /home/gus/p/ecosystem/kci-dev/kcidev/main.py

All done! ✨ 🍰 ✨
1 file reformatted, 12 files left unchanged.
Fixing /home/gus/p/ecosystem/kci-dev/kcidev/main.py

But no changes are generated:

(.venv) poutine kci-dev > git diff
(.venv) poutine kci-dev > git status 
On branch experimental-results-fetching
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	kcidev/full-next-results.json
	kcidev/subcommands/analyze-dashboard-json.py

nothing added to commit but untracked files present (use "git add" to track)

so I don't know how to make the pipeline green :(

The following command

poetry run black .

gives me the following diff

diff --git a/kcidev/main.py b/kcidev/main.py
index a8ddeea..544b2a5 100755
--- a/kcidev/main.py
+++ b/kcidev/main.py
@@ -4,8 +4,14 @@
 import click

 from kcidev.libs.common import *
-from kcidev.subcommands import (checkout, commit, maestro_results, patch,
-                                results, testretry)
+from kcidev.subcommands import (
+    checkout,
+    commit,
+    maestro_results,
+    patch,
+    results,
+    testretry,
+)


 @click.group(

[aliceinwire]

looks like isort and black are conflicting each other about the main.py import writing

[aliceinwire]

sending a patch for this

[aliceinwire]

This should fix it
#61
please update and rebase after is merged

[aliceinwire]

merged, after update and rebase should output the reformatted main.py