Fix pip build #779
Merged
Fix pip build #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tilakrayal as I am not familiar with the merging process of tf-keras, can this get merged? Or is there more action needed from my side? |
|
hi @haifeng-jin can this be merged? It's blocking us downstreams in spack to release new TFP versions |
|
FYI / For response: @tilakrayal @sachinprasadhs or @tilakrayal and @haifeng-jin: What does it take to get this approved PR merged? As the submitter @jonas-eschle pointed out in July, this would be ready for merge (for 5 months now). It blocks a stack of pull requests of the spack package manager project, starting with this PR: spack/spack#43688 |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Imported from GitHub PR #779 As discussed in #776 I tried but actually run into the issue that layers/experimental cannot be used as a build target, as the builds _inside_ experimental _require_ layers -> circular deps. The other folders in `layers` circumvent this by specifying only the specific build targets. Instead of changing the logic (i.e. is experimental meant to be dev-built only?), I did what the error advertised and added it to the ignored builds, as it's seemingly not made to be built Copybara import of the project: -- 9d3bb64 by Jonas Eschle <[email protected]>: docs: update CONTRIBUTING.md with new name tf-keras (cherry picked from commit fb79960) -- 7bd7b3d by Jonas Eschle <[email protected]>: fix: python build ignore experimental due to circular refs (cherry picked from commit 9b349e3) Merging this change closes #779 FUTURE_COPYBARA_INTEGRATE_REVIEW=#779 from jonas-eschle:fix_pip_build 7bd7b3d PiperOrigin-RevId: 685927076
Closed
sampathweb
reviewed
Oct 16, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #779 As discussed in #776 I tried but actually run into the issue that layers/experimental cannot be used as a build target, as the builds _inside_ experimental _require_ layers -> circular deps. The other folders in `layers` circumvent this by specifying only the specific build targets. Instead of changing the logic (i.e. is experimental meant to be dev-built only?), I did what the error advertised and added it to the ignored builds, as it's seemingly not made to be built Copybara import of the project: -- 9d3bb64 by Jonas Eschle <[email protected]>: docs: update CONTRIBUTING.md with new name tf-keras (cherry picked from commit fb79960) -- 7bd7b3d by Jonas Eschle <[email protected]>: fix: python build ignore experimental due to circular refs (cherry picked from commit 9b349e3) Merging this change closes #779 FUTURE_COPYBARA_INTEGRATE_REVIEW=#779 from jonas-eschle:fix_pip_build 7bd7b3d PiperOrigin-RevId: 685927076
github-actions
bot
removed
the
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #776
I tried but actually run into the issue that layers/experimental cannot be used as a build target, as the builds inside experimental require layers -> circular deps. The other folders in
layerscircumvent this by specifying only the specific build targets.Instead of changing the logic (i.e. is experimental meant to be dev-built only?), I did what the error advertised and added it to the ignored builds, as it's seemingly not made to be built