cntk backend: fix the reversed rnn bug #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Aug 10, 2017
keras/backend/cntk_backend.py
Outdated
| @@ -1310,7 +1310,15 @@ def rnn(step_function, inputs, initial_states, | |||
| initial.append(s) | |||
|
|
|||
| need_convert = not has_seq_axis(inputs) | |||
| if go_backwards and need_convert is False: | |||
| raise NotImplementedError('CNTK Backend: reverse ordered rnn with ' | |||
There was a problem hiding this comment.
The error message seems unclear. Please update it to something like:
"go_backards is not support with variable-length sequences. Please specify a static-length for your sequences"
There was a problem hiding this comment.
Thanks, has updated the message.
fchollet
approved these changes
Aug 11, 2017
|
@fchollet Thanks for fix the error msg! will be more careful next time. |
ahundt
added a commit
to ahundt/keras
that referenced
this pull request
Aug 11, 2017
* master: model.fit(steps_per_epoch), mnist_tfrecord.py, progbar np.mean (keras-team#7113) Change default size to allow different MobileNet sizes (keras-team#7586) cntk backend: fix the reversed rnn bug (keras-team#7593) Fix mask for multi output --> multi inputs (keras-team#7591) [RELNOTES] Subtract merge layer (keras-team#7573) update docker with cntk 2.1 (keras-team#7565) [RELNOTES] Move constraint management to be based on variable attributes (like TF). (keras-team#7564) Add handling for `dtype` arg in initializer config. Fix keras-team#7550. (keras-team#7552) remove unnecessary function definition (keras-team#7542) refactor the function - _convert_string_dtype (keras-team#7540) Add batchnorm tests for CNTK (keras-team#7534) Clean up RNN tests (keras-team#7529) Add merge tests (keras-team#7533) # Conflicts: # examples/mnist_tfrecord.py # keras/engine/training.py # keras/utils/generic_utils.py # tests/keras/engine/test_training.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix a bug in CNTK backend, current implementation for rnn with go_backwards = True is incorrect.