Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/keras-team/keras/issues/20425 #20453

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hertschuh
Copy link
Collaborator

The issue was caused by the fact that the iterator was not fully consumed and on_epoch_end was not called.

Added an exception to catch this situation in the future.

Added a unit test to test model.fit() with all the combinations of data adapters.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (272bb90) to head (812bd8f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/src/trainers/data_adapters/py_dataset_adapter.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20453   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         514      515    +1     
  Lines       47239    47275   +36     
  Branches     7413     7422    +9     
=======================================
+ Hits        38741    38772   +31     
- Misses       6704     6706    +2     
- Partials     1794     1797    +3     
Flag Coverage Δ
keras 81.86% <62.50%> (+<0.01%) ⬆️
keras-jax 64.91% <62.50%> (+<0.01%) ⬆️
keras-numpy 59.84% <50.00%> (-0.03%) ⬇️
keras-tensorflow 65.91% <62.50%> (+<0.01%) ⬆️
keras-torch 64.83% <62.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The issue was caused by the fact that the iterator was not fully consumed and `on_epoch_end` was not called.

Added an exception to catch this situation in the future.

Added a unit test to test `model.fit()` with all the combinations of data adapters.
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 5, 2024
@fchollet fchollet merged commit b91cfe5 into keras-team:master Nov 5, 2024
9 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 5, 2024
@hertschuh hertschuh deleted the data_adapter_reset branch November 5, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants