Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ops.stop_gradient for KerasTensor #20125

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

alexhartl
Copy link
Contributor

Fixes #20124.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.32%. Comparing base (6fd4873) to head (69e63e8).
Report is 182 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20125      +/-   ##
==========================================
+ Coverage   73.70%   79.32%   +5.61%     
==========================================
  Files         501      501              
  Lines       46988    46990       +2     
  Branches     8663     8664       +1     
==========================================
+ Hits        34632    37273    +2641     
+ Misses      10659     7969    -2690     
- Partials     1697     1748      +51     
Flag Coverage Δ
keras 79.17% <100.00%> (+5.54%) ⬆️
keras-jax 62.49% <100.00%> (+<0.01%) ⬆️
keras-numpy 57.55% <100.00%> (+<0.01%) ⬆️
keras-tensorflow 63.85% <100.00%> (+<0.01%) ⬆️
keras-torch 62.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 15, 2024
@fchollet fchollet merged commit 4cef332 into keras-team:master Aug 15, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ops.stop_gradient does not work with KerasTensor
4 participants