Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate numpy namespace to numpy 2.0 #20049

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

grasskin
Copy link
Member

Numpy 2.0 deprecates part of their namespace, see https://numpy.org/doc/stable/numpy_2_0_migration_guide.html for all details.
Keras is affected by np.Inf -> np.inf and np.unicode_ -> np.str_.

Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (7d92e9e) to head (b28f425).

Files Patch % Lines
keras/src/callbacks/reduce_lr_on_plateau.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20049   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files         501      501           
  Lines       46921    46921           
  Branches     8648     8648           
=======================================
  Hits        37195    37195           
  Misses       7981     7981           
  Partials     1745     1745           
Flag Coverage Δ
keras 79.12% <83.33%> (ø)
keras-jax 62.46% <83.33%> (ø)
keras-numpy 57.51% <0.00%> (ø)
keras-tensorflow 63.80% <83.33%> (ø)
keras-torch 62.51% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@fchollet fchollet merged commit a226835 into keras-team:master Jul 26, 2024
10 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jul 26, 2024
@adamjstewart
Copy link

Probably closes #19691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants