Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tensorflow support for variable scatter_update in optimizers. #19313

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

hertschuh
Copy link
Collaborator

@hertschuh hertschuh commented Mar 14, 2024

This should have been added along with scatter_add and scatter_sub as part of #18692 as it was added in the super class: https://github.com/keras-team/keras/blob/master/keras/optimizers/base_optimizer.py#L222

Fixes #19281

@hertschuh hertschuh changed the title Add Tensorflow support for variable scatter_udpate in optimizers. Add Tensorflow support for variable scatter_update in optimizers. Mar 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 54.45%. Comparing base (c8700f4) to head (bb9551b).
Report is 98 commits behind head on master.

Files Patch % Lines
keras/backend/tensorflow/optimizer.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19313       +/-   ##
===========================================
- Coverage   80.14%   54.45%   -25.69%     
===========================================
  Files         341      366       +25     
  Lines       36163    40078     +3915     
  Branches     7116     7771      +655     
===========================================
- Hits        28982    21825     -7157     
- Misses       5578    16662    +11084     
+ Partials     1603     1591       -12     
Flag Coverage Δ
keras 54.45% <0.00%> (-25.54%) ⬇️
keras-jax ?
keras-numpy 54.45% <0.00%> (-2.63%) ⬇️
keras-tensorflow ?
keras-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Mar 14, 2024
@fchollet fchollet merged commit 3fcb38c into keras-team:master Mar 14, 2024
8 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Mar 14, 2024
@hertschuh hertschuh deleted the optimizer_scatter_update branch March 14, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

Scatter update variable in TF optimizer
4 participants