-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(preprocessing): resolve ValueError
for ngrams
tuple
#19190
Fix(preprocessing): resolve ValueError
for ngrams
tuple
#19190
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Resolves a deserialisation issue when `ngrams` is set to a tuple in `TextVectorization` layer. Closes keras-team#19180
d6be26f
to
d9ab507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Please add a unit test (so we avoid breaking it in the future...)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19190 +/- ##
==========================================
- Coverage 80.14% 75.48% -4.67%
==========================================
Files 341 362 +21
Lines 36163 39049 +2886
Branches 7116 7564 +448
==========================================
+ Hits 28982 29475 +493
- Misses 5578 7948 +2370
- Partials 1603 1626 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…orflow` backend only
Resolves a deserialisation issue when
ngrams
is set to a tuple inTextVectorization
layer. Closes #19180.