-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add erfinv
op
#19107
Add erfinv
op
#19107
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good -- thanks for the contribution!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #19107 +/- ##
==========================================
+ Coverage 79.94% 79.96% +0.01%
==========================================
Files 340 340
Lines 35845 35866 +21
Branches 7050 7051 +1
==========================================
+ Hits 28656 28679 +23
+ Misses 5596 5595 -1
+ Partials 1593 1592 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Adds the inverse error function (
erfinv
) function to the supported ops. It's widely used in statistics, probability and numerical applications, complements theerf
op which is available and is easily implemented since it's already supported by all backends.