Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erfinv op #19107

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Add erfinv op #19107

merged 6 commits into from
Jan 26, 2024

Conversation

frazane
Copy link
Contributor

@frazane frazane commented Jan 26, 2024

Adds the inverse error function (erfinv) function to the supported ops. It's widely used in statistics, probability and numerical applications, complements the erf op which is available and is easily implemented since it's already supported by all backends.

Copy link

google-cla bot commented Jan 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good -- thanks for the contribution!

keras/ops/math.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d55a293) 79.94% compared to head (cb9749a) 79.96%.
Report is 4 commits behind head on master.

Files Patch % Lines
keras/ops/math.py 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19107      +/-   ##
==========================================
+ Coverage   79.94%   79.96%   +0.01%     
==========================================
  Files         340      340              
  Lines       35845    35866      +21     
  Branches     7050     7051       +1     
==========================================
+ Hits        28656    28679      +23     
+ Misses       5596     5595       -1     
+ Partials     1593     1592       -1     
Flag Coverage Δ
keras 79.81% <80.00%> (+0.01%) ⬆️
keras-jax 62.62% <55.00%> (-0.01%) ⬇️
keras-numpy 57.10% <60.00%> (+0.01%) ⬆️
keras-tensorflow 64.77% <55.00%> (-0.01%) ⬇️
keras-torch 63.95% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 26, 2024
@fchollet fchollet merged commit 47bf22d into keras-team:master Jan 26, 2024
5 of 6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 26, 2024
@frazane frazane deleted the op-erfinv branch February 1, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants