Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inplace operation in LSTM when using torch backend #19010

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

dugujiujian1999
Copy link
Contributor

Fix #18958

Copy link

google-cla bot commented Jan 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gbaned
Copy link
Collaborator

gbaned commented Jan 2, 2024

Hi @dugujiujian1999 Can you please sign CLA. Thank you!

@gbaned gbaned added stat:awaiting keras-eng Awaiting response from Keras engineer stat:awaiting response from contributor and removed awaiting review stat:awaiting keras-eng Awaiting response from Keras engineer labels Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccc202a) 79.65% compared to head (4202615) 75.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19010      +/-   ##
==========================================
- Coverage   79.65%   75.40%   -4.26%     
==========================================
  Files         339      339              
  Lines       35466    35466              
  Branches     6979     6979              
==========================================
- Hits        28251    26742    -1509     
- Misses       5613     7176    +1563     
+ Partials     1602     1548      -54     
Flag Coverage Δ
keras 75.28% <100.00%> (-4.23%) ⬇️
keras-jax ?
keras-numpy 55.78% <0.00%> (ø)
keras-tensorflow 63.20% <100.00%> (ø)
keras-torch 63.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dugujiujian1999
Copy link
Contributor Author

@gbaned Ok. Signed. Thank you.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 2, 2024
@fchollet fchollet merged commit 63dc12d into keras-team:master Jan 2, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

RuntimeError for LSTM with dropout and torch backend
4 participants