Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden folders for image_dataset_from_directory #18177

Merged
merged 8 commits into from
Jun 30, 2023

Conversation

sachinprasadhs
Copy link
Collaborator

Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
Fixes: keras-team/tf-keras#187

Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
@sachinprasadhs sachinprasadhs added the keras-team-review-pending Pending review by a Keras team member. label May 30, 2023
@ARPIT2128
Copy link

Lint will reject it due to IndentationError try in one line 😃

@nkovela1
Copy link
Contributor

nkovela1 commented Jun 1, 2023

Please fix the code formatting. The change LGTM otherwise!

@gbaned gbaned requested a review from nkovela1 June 2, 2023 03:42
@gbaned gbaned removed keras-team-review-pending Pending review by a Keras team member. awaiting review labels Jun 2, 2023
@gbaned gbaned requested review from nkovela1 and removed request for nkovela1 June 8, 2023 08:44
@ARPIT2128
Copy link

ARPIT2128 commented Jun 19, 2023

@sachinprasadhs
Copy link
Collaborator Author

@nkovela1 Could you please review it.

Copy link
Contributor

@nkovela1 nkovela1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @fchollet for merge access. LGTM!

copybara-service bot pushed a commit that referenced this pull request Jun 30, 2023
Imported from GitHub PR #18177

Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
Fixes: https://github.com/keras-team/keras/issues/18170
Copybara import of the project:

--
489e279 by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory

Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
--
ed62b30 by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
3f86351 by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
64d91d4 by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
9870b10 by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
31af45e by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
9bc903b by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory
--
e337f3a by Sachin Prasad <[email protected]>:

Ignore hidden folders for image_dataset_from_directory

Merging this change closes #18177

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18177 from keras-team:sachinprasadhs-patch-5 e337f3a
PiperOrigin-RevId: 544701876
@copybara-service copybara-service bot merged commit 428ed9f into master Jun 30, 2023
@sachinprasadhs sachinprasadhs deleted the sachinprasadhs-patch-5 branch February 1, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ready to pull Ready to be merged into the codebase size:XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to take some sub-directories from a main directory tf.keras.utils.image_dataset_from_directory
5 participants