-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore hidden folders for image_dataset_from_directory #18177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
sachinprasadhs
added
the
keras-team-review-pending
Pending review by a Keras team member.
label
May 30, 2023
ARPIT2128
reviewed
May 31, 2023
Lint will reject it due to |
Please fix the code formatting. The change LGTM otherwise! |
gbaned
removed
keras-team-review-pending
Pending review by a Keras team member.
awaiting review
labels
Jun 2, 2023
@nkovela1 Could you please review it. |
nkovela1
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @fchollet for merge access. LGTM!
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Ready to be merged into the codebase
labels
Jun 28, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
Imported from GitHub PR #18177 Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc. Fixes: https://github.com/keras-team/keras/issues/18170 Copybara import of the project: -- 489e279 by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc. -- ed62b30 by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- 3f86351 by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- 64d91d4 by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- 9870b10 by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- 31af45e by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- 9bc903b by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory -- e337f3a by Sachin Prasad <[email protected]>: Ignore hidden folders for image_dataset_from_directory Merging this change closes #18177 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18177 from keras-team:sachinprasadhs-patch-5 e337f3a PiperOrigin-RevId: 544701876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore hidden folders for image_dataset_from_directory like .git .ipynb etc.
Fixes: keras-team/tf-keras#187