Consistently use "pickleable" instead of "picklable" #18140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinprasadhs
added
the
keras-team-review-pending
qlzh727
approved these changes
Jun 7, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
qlzh727
removed
the
keras-team-review-pending
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Imported from GitHub PR #18140 Just a nitpick: All code in [TensorFlow](https://github.com/search?q=repo%3Atensorflow%2Ftensorflow%20pickleable&type=code) and Keras (GitHub's code search misses most) uses _pickleable_, but in some parts of Keras' documentation it's called _picklable_. This is hereby fixed. Note that I am not a native English speaker, but the [Wiktionary](https://en.wiktionary.org/wiki/pickleable) agrees. _This supercedes my PR against TensorFlow: https://github.com/tensorflow/tensorflow/pull/60631_. Copybara import of the project: -- d2afce2 by Nicolai Weitkemper <[email protected]>: Consistently use "pickleable" instead of "picklable" Merging this change closes #18140 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18140 from NicoWeio:pickl-e-able d2afce2 PiperOrigin-RevId: 538823428
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Imported from GitHub PR #18140 Just a nitpick: All code in [TensorFlow](https://github.com/search?q=repo%3Atensorflow%2Ftensorflow%20pickleable&type=code) and Keras (GitHub's code search misses most) uses _pickleable_, but in some parts of Keras' documentation it's called _picklable_. This is hereby fixed. Note that I am not a native English speaker, but the [Wiktionary](https://en.wiktionary.org/wiki/pickleable) agrees. _This supercedes my PR against TensorFlow: https://github.com/tensorflow/tensorflow/pull/60631_. Copybara import of the project: -- d2afce2 by Nicolai Weitkemper <[email protected]>: Consistently use "pickleable" instead of "picklable" Merging this change closes #18140 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18140 from NicoWeio:pickl-e-able d2afce2 PiperOrigin-RevId: 538823428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a nitpick: All code in TensorFlow and Keras (GitHub's code search misses most) uses pickleable, but in some parts of Keras' documentation it's called picklable. This is hereby fixed.
Note that I am not a native English speaker, but the Wiktionary agrees.
This supercedes my PR against TensorFlow: tensorflow/tensorflow#60631.