Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/applications/efficientnet.py] Standardise docstring usage of "Default to" #17758

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

@gbaned gbaned requested a review from qlzh727 April 4, 2023 05:39
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 4, 2023
keras/applications/convnext.py Outdated Show resolved Hide resolved
keras/applications/efficientnet.py Outdated Show resolved Hide resolved
@haifeng-jin haifeng-jin removed the keras-team-review-pending Pending review by a Keras team member. label Apr 5, 2023
@haifeng-jin
Copy link
Contributor

Pending on author's change.

@SamuelMarks
Copy link
Contributor Author

@haifeng-jin Fixed

@gbaned gbaned requested a review from haifeng-jin April 13, 2023 11:07
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
keras/applications/convnext.py Outdated Show resolved Hide resolved
@gbaned gbaned removed the keras-team-review-pending Pending review by a Keras team member. label Apr 21, 2023
Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more comments from me.

@gbaned gbaned requested a review from haifeng-jin May 4, 2023 08:22
@gbaned gbaned added the keras-team-review-pending Pending review by a Keras team member. label May 4, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 4, 2023
copybara-service bot pushed a commit that referenced this pull request May 5, 2023
… usage of "Default to"

Imported from GitHub PR #17758

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
336f0ee by Samuel Marks <[email protected]>:

[keras/applications/convnext.py] Standardise docstring usage of "Defaults to"

--
4107acf by Samuel Marks <[email protected]>:

[keras/applications/efficientnet.py] Standardise docstring usage of "Defaults to"

--
b391c10 by Samuel Marks <[email protected]>:

[keras/applications/efficientnet.py] Remove {mode} from docstring

--
f8622ce by Samuel Marks <[email protected]>:

[keras/applications/convnext.py] Revert changes to this file as this branch telos is a one-file change

Merging this change closes #17758

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17758 from SamuelMarks:keras.applications.efficientnet f8622ce
PiperOrigin-RevId: 529706725
@copybara-service copybara-service bot merged commit b7e9134 into keras-team:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keras-team-review-pending Pending review by a Keras team member. ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants