-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keras/applications/efficientnet.py] Standardise docstring usage of "Default to" #17758
Merged
copybara-service
merged 5 commits into
keras-team:master
from
SamuelMarks:keras.applications.efficientnet
May 5, 2023
Merged
[keras/applications/efficientnet.py] Standardise docstring usage of "Default to" #17758
copybara-service
merged 5 commits into
keras-team:master
from
SamuelMarks:keras.applications.efficientnet
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-ml-butler
bot
added
the
keras-team-review-pending
Pending review by a Keras team member.
label
Apr 4, 2023
qlzh727
requested changes
Apr 4, 2023
haifeng-jin
removed
the
keras-team-review-pending
Pending review by a Keras team member.
label
Apr 5, 2023
Pending on author's change. |
@haifeng-jin Fixed |
google-ml-butler
bot
added
the
keras-team-review-pending
Pending review by a Keras team member.
label
Apr 13, 2023
qlzh727
requested changes
Apr 20, 2023
gbaned
removed
the
keras-team-review-pending
Pending review by a Keras team member.
label
Apr 21, 2023
haifeng-jin
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No more comments from me.
…branch telos is a one-file change
haifeng-jin
approved these changes
May 4, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Ready to be merged into the codebase
labels
May 4, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
May 5, 2023
… usage of "Default to" Imported from GitHub PR #17758 This is one of many PRs. Discussion + request to split into multiple PRs @ #17748 Copybara import of the project: -- 336f0ee by Samuel Marks <[email protected]>: [keras/applications/convnext.py] Standardise docstring usage of "Defaults to" -- 4107acf by Samuel Marks <[email protected]>: [keras/applications/efficientnet.py] Standardise docstring usage of "Defaults to" -- b391c10 by Samuel Marks <[email protected]>: [keras/applications/efficientnet.py] Remove {mode} from docstring -- f8622ce by Samuel Marks <[email protected]>: [keras/applications/convnext.py] Revert changes to this file as this branch telos is a one-file change Merging this change closes #17758 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17758 from SamuelMarks:keras.applications.efficientnet f8622ce PiperOrigin-RevId: 529706725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
keras-team-review-pending
Pending review by a Keras team member.
ready to pull
Ready to be merged into the codebase
size:S
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of many PRs. Discussion + request to split into multiple PRs @ #17748