Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected DepthwiseConv1D docstring #16807

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Corrected DepthwiseConv1D docstring #16807

merged 3 commits into from
Jul 22, 2022

Conversation

AdityaKane2001
Copy link
Contributor

@AdityaKane2001 AdityaKane2001 commented Jul 19, 2022 •
edited
Loading

@fchollet @qlzh727

Corrected docstring for DepthwiseConv1D. Essentially replaced 4D -> 3D in tensor type and made relevant changes.

/cc @omkargokhale2001

@AdityaKane2001 AdityaKane2001 changed the title Corrected docstring Corrected DepthwiseCOnv1D docstring Jul 19, 2022
@AdityaKane2001 AdityaKane2001 changed the title Corrected DepthwiseCOnv1D docstring Corrected DepthwiseConv1D docstring Jul 19, 2022
@gbaned gbaned requested a review from fchollet July 19, 2022 13:14
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Jul 19, 2022
fchollet
fchollet approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 19, 2022
@fchollet
Copy link
Member

Lint / Check the code format (pull_request) Failing after 1m — Check the code format

Please fix code style.

Also for consistency prefer using input_dim instead of dims

@fchollet fchollet removed ready to pull Ready to be merged into the codebase keras-team-review-pending Pending review by a Keras team member. labels Jul 19, 2022
@AdityaKane2001
Copy link
Contributor Author

@fchollet Made requested changes.

@gbaned gbaned requested a review from fchollet July 20, 2022 04:45
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Jul 20, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 20, 2022
@fchollet fchollet removed the keras-team-review-pending Pending review by a Keras team member. label Jul 20, 2022
@AdityaKane2001
Copy link
Contributor Author

@gbaned @fchollet Please take a look at this one. TIA

@copybara-service copybara-service bot merged commit 65d9178 into keras-team:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdityaKane2001 @fchollet @kokoro-team @gbaned