Formatted callback.py to render correctly #16765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated some formatting to render the code block correctly
google-ml-butler
bot
added
the
keras-team-review-pending
|
Thanks for the PR! The code change will be problematic because it's using doctest which attempts to run the example code, but it's actually not runnable. Can you do the couple things instead: 1) add 'python' after the initial '```' and 2) fix the indentation. |
Updated based on your suggestion. Please review |
fchollet
approved these changes
Jul 7, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
|
Please fix the code formatting: |
gbaned
removed
keras-team-review-pending
Updated. Please review. Thanks |
fchollet
approved these changes
Jul 8, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
fchollet
reviewed
Jul 8, 2022
keras/callbacks.py
Outdated
| @@ -654,7 +654,8 @@ class Callback: | |||
| callbacks.on_epoch_end(epoch, epoch_logs) | |||
| final_logs=... | |||
| callbacks.on_train_end(final_logs) | |||
| ``` | |||
| ``` | |||
|
|
|||
fchollet
approved these changes
Jul 12, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some formatting to render the code block correctly