Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable definitions in optimizer usage example #16731

Merged

Conversation

miker2241
Copy link
Contributor

In the current usage example the variables are not defined. This is a crucial step to be able to run the example. This PR adds the missing variable definitions.

@google-cla
Copy link

google-cla bot commented Jun 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gbaned gbaned requested a review from qlzh727 June 29, 2022 14:05
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Jun 29, 2022
@gbaned
Copy link
Collaborator

gbaned commented Jun 29, 2022

@miker2241 Can you please resolve conflicts? Thank you!

@gbaned gbaned removed the keras-team-review-pending Pending review by a Keras team member. label Jun 29, 2022
@miker2241 miker2241 force-pushed the patch-add-variable-definitions branch from 766dc1f to 5591008 Compare June 29, 2022 15:25
@miker2241
Copy link
Contributor Author

@gbaned I have rebased the PR to the latest master

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 29, 2022
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@copybara-service copybara-service bot merged commit 7dd01b1 into keras-team:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants