-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-float32 efficientnet calls #16402
Fix non-float32 efficientnet calls #16402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Are you able to run the unit tests locally?
Hey @fchollet !
This one failing test also fails on my local setup on master:
So I'm confident it's not a regression introduced on my branch! |
I'm actually concerned about "There were tests whose specified size is too big" Can you try to run the test "keras/applications/applications_load_weight_test.py" manually? |
@fchollet this passes:
(fyi the test name has a suffix _resnet in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for checking. LGTM
Fix #16401
No obvious way I could see to include a breaking example of the old pattern in tests, so left as-is given it's a one-liner.