-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Denormalization layer #16350
Denormalization layer #16350
Conversation
Thanks for the PR. I see we have an @mattdangerw what do you think? |
@fchollet Please make a review. |
Yeah, I think
We should probably also show an example of this in the docstring, taking some data, first normalizing, then inverting. For both the adapted and non-adapted cases. |
I create both unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@markub3327 thanks. Could you add an example of |
Yes, sorry I forgotten. It's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I'll do a round of copyedits in post-processing.
Ok. Thanks. |
@gadagashwini
Solved #16284