fix thresholded_relu to support list datatype #16277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for list datatype
|
Should I added a test for this too? |
google-ml-butler
bot
added
the
keras-team-review-pending
fchollet
reviewed
Mar 22, 2022
| return inputs * tf.cast(tf.greater(inputs, theta), inputs.dtype) | ||
| dtype = getattr(inputs, 'dtype', tf.keras.backend.floatx()) | ||
| theta = tf.cast(self.theta, dtype) | ||
| return inputs * tf.cast(tf.greater(inputs, theta), dtype) |
| @@ -59,8 +59,9 @@ def __init__(self, theta=1.0, **kwargs): | |||
| self.theta = backend.cast_to_floatx(theta) | |||
|
|
|||
| def call(self, inputs): | |||
| theta = tf.cast(self.theta, inputs.dtype) | |||
| return inputs * tf.cast(tf.greater(inputs, theta), inputs.dtype) | |||
| dtype = getattr(inputs, 'dtype', tf.keras.backend.floatx()) | |||
There was a problem hiding this comment.
Switch to dtype = self.compute_dtype
fchollet
removed
the
keras-team-review-pending
`dtype = self.compute_dtype` from `getattr` and removed cast of `theta`
google-ml-butler
bot
added
the
keras-team-review-pending
|
A tangent to the problem and probably a learning point for some: |
LukeWood
removed
the
keras-team-review-pending
|
Looks like some comments are still unresolved on the PR. unassigning from Keras team for now. |
|
The two comments:
has been done. Would you please point out to what else comments are unresolved @LukeWood ? |
fchollet
approved these changes
Mar 27, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
added
the
keras-team-review-pending
gbaned
removed
the
keras-team-review-pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for list datatype in thresholded_relu similar to relu.
Notebook with the issue and solution.
Auto closes #16273