refactoring code with List Comprehension #15924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring code with List Comprehension which is more pythonic, concise and efficient
google-ml-butler
bot
added
the
keras-team-review-pending
qlzh727
removed
the
keras-team-review-pending
rchao
reviewed
Jan 20, 2022
keras/callbacks_test.py
Outdated
| @@ -1790,11 +1790,9 @@ def data_generator(): | |||
|
|
|||
| values = [] | |||
| with open(fp) as f: | |||
| for x in csv.reader(f): | |||
| # In windows, due to \r\n line ends we may end up reading empty lines | |||
| values = [x for x in csv.reader(f) if x]# In windows, due to \r\n line ends we may end up reading empty lines | |||
There was a problem hiding this comment.
Thanks for the PR! The change looks reasonable. Can you re-format the comment?
fchollet
approved these changes
Jan 20, 2022
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
the
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring code with List Comprehension which is more pythonic, concise and efficient; how do you think this change which has practical value？