-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace os.path.join with tf.io.gfile.join #15551
chore: replace os.path.join with tf.io.gfile.join #15551
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
3a5f614
to
b0ae4a5
Compare
@gbaned can you kick off CI please? I'll give this another pass in the next couple days, I can already see plenty of places I don't think replacement was needed |
I went through this by eye. The main change I made was to revert (i.e. make no changes) to I think all of the replacements left now directly pertain to SavedModel, which is the context where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Partially addresses #15300
I only replaced some uses of
os.path.join
.I didn't want to replace it where not needed (it is only needed in things that interact
ram://
orgcs://
filesystems). But I probably replied it in some places where it's not needed and neglected to replace it in places where it is needed. The codebase is very large and I'm unfamiliar with a lot of it; I'd appreciate some guidance from someone with more global knowledge of the codebase.