Fix the use of imagenet_utils.preprocess_input within a Lambda layer with mixed precision #14917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
added
kokoro:force-run
ready to pull
anth2o
deleted the
fix-imagenet-preprocessing-within-lambda-layer-mixed-precision
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue when using imagenet_utils.preprocess_input within a Lambda layer and using mixed precision. I described it and gave a minimal reproducible example here.
This PR is a very small bugfix, with the add of a unit test of the problematic behavior. If you remove the added line in
imagenet_utils.py, the testtest_preprocess_input_symbolic_mixed_precisionin test modetorchwill fail.